Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-67226

Deduplication of traces doesn't work for UserRPCRequest

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • 2.323

      https://github.com/jenkinsci/jenkins/blob/55c31c892c224b7bd12714ec1c20dbeae68defde/core/src/main/java/jenkins/telemetry/impl/SlaveToMasterFileCallableUsage.java#L72 is an attempt to deduplicate traces with object identities.

      Unfortunately, this doesn't work with traces from UserRPCRequest, that include a counter:

      Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](26) created at
      …
      
      Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](27) created at
      …
      
      Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](28) created at 
      …

      Another source for duplication is proxies:

      	at com.sun.proxy.$Proxy5.end(Unknown Source)
      
      	at com.sun.proxy.$Proxy6.end(Unknown Source) 

          [JENKINS-67226] Deduplication of traces doesn't work for UserRPCRequest

          Daniel Beck created issue -
          Daniel Beck made changes -
          Description Original: [https://github.com/jenkinsci/jenkins/blob/55c31c892c224b7bd12714ec1c20dbeae68defde/core/src/main/java/jenkins/telemetry/impl/SlaveToMasterFileCallableUsage.java#L72] is an attempt to deduplicate traces with object identities.

          Unfortunately, this doesn't work with traces from {{UserRPCRequest}}, that include a counter:
          {noformat}
          Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](26) created at


          Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](27) created at


          Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](28) created at
          …{noformat}
          New: [https://github.com/jenkinsci/jenkins/blob/55c31c892c224b7bd12714ec1c20dbeae68defde/core/src/main/java/jenkins/telemetry/impl/SlaveToMasterFileCallableUsage.java#L72] is an attempt to deduplicate traces with object identities.

          Unfortunately, this doesn't work with traces from {{UserRPCRequest}}, that include a counter:
          {noformat}
          Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](26) created at


          Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](27) created at


          Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](28) created at
          …{noformat}
          Another source for duplication is proxies:
          {noformat}
          at com.sun.proxy.$Proxy5.end(Unknown Source)

          at com.sun.proxy.$Proxy6.end(Unknown Source) {noformat}
          Jesse Glick made changes -
          Epic Link New: JENKINS-67173 [ 213575 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "jenkins #5957 (Web Link)" [ 27261 ]
          Jesse Glick made changes -
          Assignee New: Daniel Beck [ danielbeck ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Jesse Glick made changes -
          Released As New: 2.323
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Fixed but Unreleased [ 10203 ]
          Mark Waite made changes -
          Status Original: Fixed but Unreleased [ 10203 ] New: Closed [ 6 ]
          Cathy made changes -
          Labels New: 2.319.2-fixed

            danielbeck Daniel Beck
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: