Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68286

layout:icon doesn't accept extra class attribute

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • core
    • None
    • jenkins-2.164.3
      jenkins-2.343
    • 2.347

    Description

      Found in https://github.com/jenkinsci/copyartifact-plugin/pull/147.
      Class attributes of layout:icon custom tag are used to specify icons, and extra developer-defined class results to fail to find icon.

      It blocks plugins migrating img to layout:icon, which triggered by https://github.com/jenkinsci/jenkins/pull/5778 .

      TODO:

      Attachments

        Activity

          ikedam ikedam added a comment -

          This will be released in jenkins-2.347

          ikedam ikedam added a comment - This will be released in jenkins-2.347
          ikedam ikedam added a comment - https://github.com/jenkinsci/jenkins/pull/6510
          ikedam ikedam added a comment -

          layout:icon was introduced in https://github.com/jenkinsci/jenkins/pull/6186

          ikedam ikedam added a comment - layout:icon was introduced in https://github.com/jenkinsci/jenkins/pull/6186
          ikedam ikedam added a comment -
          ikedam ikedam added a comment - I cannot get what this is: https://github.com/jenkinsci/jenkins/blob/jenkins-2.344/core/src/main/java/hudson/Functions.java#L2292-L2293 This makes `tryGetIcon` difficult to test.
          ikedam ikedam added a comment -

          Classes for built-in icons are started with `icon-`, but it's not documented one and plugins may register icons without icon- prefix: https://github.com/jenkinsci/jenkins/blob/jenkins-2.344/core/src/main/java/org/jenkins/ui/icon/Icon.java#L71

          ikedam ikedam added a comment - Classes for built-in icons are started with `icon-`, but it's not documented one and plugins may register icons without icon- prefix: https://github.com/jenkinsci/jenkins/blob/jenkins-2.344/core/src/main/java/org/jenkins/ui/icon/Icon.java#L71
          ikedam ikedam added a comment - Icons are registered with `IconSet.icons.addIcon`: https://github.com/jenkinsci/jenkins/blob/jenkins-2.344/core/src/main/java/org/jenkins/ui/icon/IconSet.java#L145 Built-in icons: https://github.com/jenkinsci/jenkins/blob/jenkins-2.344/core/src/main/java/org/jenkins/ui/icon/IconSet.java#L348 https://github.com/jenkinsci/jenkins/blob/jenkins-2.344/core/src/main/java/org/jenkins/ui/icon/IconSet.java#L554 https://github.com/jenkinsci/jenkins/blob/jenkins-2.344/core/src/main/java/hudson/model/FreeStyleProject.java#L115

          People

            ikedam ikedam
            ikedam ikedam
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: