Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68904

Frontend build is not lint-clean

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Running mvn clean verify one sees a significant number of linter violations in the yarn lint phase. https://github.com/jenkinsci/jenkins/pull/6720 addresses some of the violations, but many still remain. Fixing these violations is a prerequisite for ensuring that the introduction of a new frontend lint violation fails the build in JENKINS-68903.

          [JENKINS-68904] Frontend build is not lint-clean

          Basil Crow created issue -
          Basil Crow made changes -
          Link New: This issue is blocking JENKINS-68903 [ JENKINS-68903 ]
          Basil Crow made changes -
          Epic Link New: JENKINS-68905 [ 215835 ]

          Basil Crow added a comment -

          https://github.com/jenkinsci/jenkins/pull/6720 by notmyfault fixes 112 warnings! 🥳 That puts a big dent in this task, which is excellent.

          Basil Crow added a comment - https://github.com/jenkinsci/jenkins/pull/6720 by notmyfault fixes 112 warnings! 🥳 That puts a big dent in this task, which is excellent.

          Alexander Brandes added a comment - - edited

          To add up some more information, there are two kinds of lint failures that need to be addressed. Stylelint for CSS and ESLint for JS. To list open issues in a quicker way than using maven verify step, we can invoke the npm binary directly via npx, like "npx eslint ." or "npx stylelint src/main/less" to run them separately from the war directory.

          Alexander Brandes added a comment - - edited To add up some more information, there are two kinds of lint failures that need to be addressed. Stylelint for CSS and ESLint for JS. To list open issues in a quicker way than using maven verify step, we can invoke the npm binary directly via npx, like " npx eslint . " or " npx stylelint src/main/less " to run them separately from the war directory.
          Alexander Brandes made changes -
          Remote Link New: This issue links to "Initial work - Stylelint (Web Link)" [ 27928 ]
          Alexander Brandes made changes -
          Remote Link Original: This issue links to "Initial work - Stylelint (Web Link)" [ 27928 ]
          Alexander Brandes made changes -
          Remote Link New: This issue links to "Stylelint - Initial work under 13.x (Web Link)" [ 27929 ]
          Alexander Brandes made changes -
          Remote Link New: This issue links to "Stylelint - Cleanup and fixing issues under 14.x (Web Link)" [ 27930 ]
          Alexander Brandes made changes -
          Remote Link New: This issue links to "ESLint - Fixes under 7.x (Web Link)" [ 27935 ]

            notmyfault Alexander Brandes
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: