• Type: Bug
• Resolution: Fixed
• Priority: Blocker
• Component/s: core
• Labels:

  None
• Environment:

  Tip of trunk, https://github.com/jenkinsci/jenkins/commit/76e5c98dd3c92ee892c7d094d246602be2e1dc79

[JENKINS-68933] Jetty 10 upgrade breaks websockets support

Tim Jacomb created issue - 2022-07-05 09:00

Tim Jacomb made changes - 2022-07-05 09:01

Description

Original: This line returns false since Jetty 10 upgrade: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/jenkins/websocket/WebSockets.java#L89 Because it fails to load the required Jetty classes, there's been at least package name changes if not more. Steps to reproduce: 1. Create an agent with websocket checkbox enabled 2. Form validation will reply with "WebSocket support is not enabled in this Jenkins installation" If you enable a FINE log recorder for `jenkins.websocket.WebSockets` you get a class not found exception

New: Introduced in https://github.com/jenkinsci/jenkins/pull/6694 This line returns false since Jetty 10 upgrade: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/jenkins/websocket/WebSockets.java#L89 Because it fails to load the required Jetty classes, there's been at least package name changes if not more. Steps to reproduce: 1. Create an agent with websocket checkbox enabled 2. Form validation will reply with "WebSocket support is not enabled in this Jenkins installation" If you enable a FINE log recorder for `jenkins.websocket.WebSockets` you get a class not found exception

Jesse Glick made changes - 2022-07-05 12:46

Description

Original: Introduced in https://github.com/jenkinsci/jenkins/pull/6694 This line returns false since Jetty 10 upgrade: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/jenkins/websocket/WebSockets.java#L89 Because it fails to load the required Jetty classes, there's been at least package name changes if not more. Steps to reproduce: 1. Create an agent with websocket checkbox enabled 2. Form validation will reply with "WebSocket support is not enabled in this Jenkins installation" If you enable a FINE log recorder for `jenkins.websocket.WebSockets` you get a class not found exception

New: Introduced in https://github.com/jenkinsci/jenkins/pull/6694 This line returns false since Jetty 10 upgrade: https://github.com/jenkinsci/jenkins/blob/76e5c98dd3c92ee892c7d094d246602be2e1dc79/core/src/main/java/jenkins/websocket/WebSockets.java#L89 Because it fails to load the required Jetty classes, there's been at least package name changes if not more. Steps to reproduce: 1. Create an agent with websocket checkbox enabled 2. Form validation will reply with "WebSocket support is not enabled in this Jenkins installation" If you enable a FINE log recorder for `jenkins.websocket.WebSockets` you get a class not found exception

Jesse Glick made changes - 2022-07-05 12:53

Assignee

New: Jesse Glick [ jglick ]

Jesse Glick made changes - 2022-07-05 12:53

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Jesse Glick made changes - 2022-07-05 13:44

Remote Link

New: This issue links to "jenkins #6780 (Web Link)" [ 27924 ]

Basil Crow made changes - 2022-07-08 23:35

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Basil Crow made changes - 2022-07-20 00:41

Assignee

Original: Jesse Glick [ jglick ]

New: Basil Crow [ basil ]

Basil Crow made changes - 2022-07-20 00:41

Remote Link

Original: This issue links to "jenkins #6780 (Web Link)" [ 27924 ]

Basil Crow made changes - 2022-07-20 00:41

Remote Link

New: This issue links to "jenkinsci/jenkins#6801 (Web Link)" [ 27981 ]

Load more newer events