Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6893

Fix flexmojos testing results reporting when running a maven2 build for flex projects

    XMLWordPrintable

    Details

    • Type: Patch
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core, maven-plugin
    • Labels:
      None
    • Environment:
      maven2 + flexmojos > 3.5.0 + flex unit testing libraries
    • Similar Issues:

      Description

      When running flex related test cases in a maven2 build hudson will not retrieve the test results because it will only listen to surefire:test mojo. Flexmojos will behave similarly with surefire:test (put the results to target/surefire-results folder in the proper format) but Hudson will not pick the results after a build.

      One fix is to unconditionally run surefire:test on the project but in this way when the build fails the surefire:test mojos will not be run and the tests will not be picked up.

      This patch fixed the list of mojos observed by hudson for a maven build to treat flexmojos-maven-plugin:test-run mojo the same way it will treat a surefire:test mojo execution.

      The behaviour is the expected one:
      on a successfull build the test results are picked
      on a failed build the test results are picked too.

        Attachments

          Issue Links

            Activity

            mtoader mtoader created issue -
            mtoader mtoader made changes -
            Field Original Value New Value
            Attachment enable_test_results_collection_from_flexmojos_testing.patch [ 19552 ]
            Description Index: src/main/java/hudson/maven/reporters/SurefireArchiver.java
            ===================================================================
            --- src/main/java/hudson/maven/reporters/SurefireArchiver.java (revision 32408)
            +++ src/main/java/hudson/maven/reporters/SurefireArchiver.java (working copy)
            @@ -135,6 +135,7 @@
             
                 private boolean isSurefireTest(MojoInfo mojo) {
                     if ((!mojo.is("com.sun.maven", "maven-junit-plugin", "test"))
            + && (!mojo.is("org.sonatype.flexmojos", "flexmojos-maven-plugin", "test-run"))
                         && (!mojo.is("org.apache.maven.plugins", "maven-surefire-plugin", "test")))
                         return false;
             
            @@ -168,6 +169,13 @@
                                 return false;
                             }
                         }
            + else if (mojo.is("org.sonatype.flexmojos", "flexmojos-maven-plugin", "test-run")) {
            + Boolean skipTests = mojo.getConfigurationValue("skipTest", Boolean.class);
            +
            + if (((skipTests != null) && (skipTests))) {
            + return false;
            + }
            + }
             
                     } catch (ComponentConfigurationException e) {
                         return false;
            When running flex related test cases in a maven2 build hudson will not retrieve the test results because it will only listen to surefire:test mojo. Flexmojos will behave similarly with surefire:test (put the results to target/surefire-results folder in the proper format) but Hudson will not pick the results after a build.

            One fix is to unconditionally run surefire:test on the project but in this way when the build fails the surefire:test mojos will not be run and the tests will not be picked up.

            This patch fixed the list of mojos obeserved by hudson for a maven build to treat flexmojos-maven-plugin:test-run mojo the same way it will treat a surefire:test mojo execution.

            The behaviour is the expected one:
              on a successfull build the test results are picked
              on a failed build the test results are picked too.

            mtoader mtoader made changes -
            Description When running flex related test cases in a maven2 build hudson will not retrieve the test results because it will only listen to surefire:test mojo. Flexmojos will behave similarly with surefire:test (put the results to target/surefire-results folder in the proper format) but Hudson will not pick the results after a build.

            One fix is to unconditionally run surefire:test on the project but in this way when the build fails the surefire:test mojos will not be run and the tests will not be picked up.

            This patch fixed the list of mojos obeserved by hudson for a maven build to treat flexmojos-maven-plugin:test-run mojo the same way it will treat a surefire:test mojo execution.

            The behaviour is the expected one:
              on a successfull build the test results are picked
              on a failed build the test results are picked too.

            When running flex related test cases in a maven2 build hudson will not retrieve the test results because it will only listen to surefire:test mojo. Flexmojos will behave similarly with surefire:test (put the results to target/surefire-results folder in the proper format) but Hudson will not pick the results after a build.

            One fix is to unconditionally run surefire:test on the project but in this way when the build fails the surefire:test mojos will not be run and the tests will not be picked up.

            This patch fixed the list of mojos observed by hudson for a maven build to treat flexmojos-maven-plugin:test-run mojo the same way it will treat a surefire:test mojo execution.

            The behaviour is the expected one:
              on a successfull build the test results are picked
              on a failed build the test results are picked too.

            mtoader mtoader made changes -
            Component/s core [ 15593 ]
            mtoader mtoader made changes -
            Assignee mtoader [ mtoader ]
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            kutzi kutzi made changes -
            Link This issue is duplicated by JENKINS-2367 [ JENKINS-2367 ]
            ircbot Jenkins IRC Bot made changes -
            Component/s maven-plugin [ 16033 ]
            Component/s maven2 [ 15487 ]
            adrianp Adrian Price made changes -
            Link This issue is related to JENKINS-31258 [ JENKINS-31258 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 136989 ] JNJira + In-Review [ 187337 ]

              People

              Assignee:
              mtoader mtoader
              Reporter:
              mtoader mtoader
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: