• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • github-plugin
    • None
    • 1.37.0

      Running mvn clean package on Java 17 results in the following test failures:

      The whole build exception is too long to capture, I attached it here: https://gist.github.com/NotMyFault/a210fdee7b77176b619ca3207a1b36a8

          [JENKINS-69353] github-plugin test failure on Java 17

          Alexander Brandes created issue -
          Alexander Brandes made changes -
          Description Original: Running {{mvn clean package}} on Java 17 results in the following test failures:

          The whole build exception is too long to capture, I attached it here: [https://gist.github.com/NotMyFault/a210fdee7b77176b619ca3207a1b36a8https://gist.github.com/NotMyFault/a210fdee7b77176b619ca3207a1b36a8|https://gist.github.com/NotMyFault/a210fdee7b77176b619ca3207a1b36a8]
          New: Running {{mvn clean package}} on Java 17 results in the following test failures:

          The whole build exception is too long to capture, I attached it here: https://gist.github.com/NotMyFault/a210fdee7b77176b619ca3207a1b36a8

          Basil Crow added a comment -

          Failing tests are:

          • DefaultPushGHEventListenerTest.shouldNotReceivePushHookOnWorkflowWithNoBuilds:98 » IO java.lang.RuntimeException: Failed to serialize hudson.model.Job#properties for class org.jenkinsci.plugins.workflow.job.WorkflowJob
          • DefaultPushGHEventListenerTest.shouldParsePushPayload:54 » Runtime java.io.IOException: java.lang.RuntimeException: Failed to serialize hudson.model.AbstractProject#triggers for class hudson.model.FreeStyleProject
          • DefaultPushGHEventListenerTest.shouldReceivePushHookOnWorkflow:75 » IO java.lang.RuntimeException: Failed to serialize hudson.model.Job#properties for class org.jenkinsci.plugins.workflow.job.WorkflowJob

          Basil Crow added a comment - Failing tests are: DefaultPushGHEventListenerTest.shouldNotReceivePushHookOnWorkflowWithNoBuilds:98 » IO java.lang.RuntimeException: Failed to serialize hudson.model.Job#properties for class org.jenkinsci.plugins.workflow.job.WorkflowJob DefaultPushGHEventListenerTest.shouldParsePushPayload:54 » Runtime java.io.IOException: java.lang.RuntimeException: Failed to serialize hudson.model.AbstractProject#triggers for class hudson.model.FreeStyleProject DefaultPushGHEventListenerTest.shouldReceivePushHookOnWorkflow:75 » IO java.lang.RuntimeException: Failed to serialize hudson.model.Job#properties for class org.jenkinsci.plugins.workflow.job.WorkflowJob

          Basil Crow added a comment -

          These tests are "integration tests" using JenkinsRule but yet use a Mockito based trigger, which is not a supported testing scenario. Either the tests need to be converted into pure unit tests with Mockito without JenkinsRule, or they need to be pure integration tests without the use of Mockito.

          Basil Crow added a comment - These tests are "integration tests" using JenkinsRule but yet use a Mockito based trigger, which is not a supported testing scenario. Either the tests need to be converted into pure unit tests with Mockito without JenkinsRule , or they need to be pure integration tests without the use of Mockito.
          Basil Crow made changes -
          Assignee Original: Kirill Merkushev [ lanwen ] New: Basil Crow [ basil ]
          Basil Crow made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Basil Crow made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Basil Crow made changes -
          Remote Link New: This issue links to "jenkinsci/github-plugin#328 (Web Link)" [ 28483 ]
          Basil Crow made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Fixed but Unreleased [ 10203 ]
          Basil Crow made changes -
          Released As New: 1.37.0
          Status Original: Fixed but Unreleased [ 10203 ] New: Resolved [ 5 ]

            basil Basil Crow
            notmyfault Alexander Brandes
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: