Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-69379

Don't place yui-button class on jenkins-buttons

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • credentials-plugin
    • Jenkins 2.364, Credentials plugin 1139.veb_9579fca_33b_
    • 1224.vc23ca_a_9a_2cb_0

      The following scenario can be seen in locations, where you can add credentials through the credentials plugin.

      The "+ Add" button is a jenkins-button, as it should be, but its wrapped into a span adding yui-button on top of it, which displays two buttons, like we can see on the screenshot. The grey background is the hover effect of the jenkins-button and the blue frame is the hover effect of the yui-button.

      I'm not exactly sure where the credentials plugin adds the YUI buttons on top, but that's no longer needed, given the credentials plugin already utilizes the modernized buttons.

          [JENKINS-69379] Don't place yui-button class on jenkins-buttons

          Alexander Brandes created issue -
          Alexander Brandes made changes -
          Description Original: The following scenario can be seen in locations, where you can add credentials through the credentials plugin.

          The "+ Add" button is a {{{}jenkins-button{}}}, as it should be, but its wrapped into a span adding {{yui-button}} on top of it, which displays two buttons, like we can see on the screenshot. The grey background is the hover effect of the jenkins-button and the blue frame is the hover effect of the yui-button.

           

          I'm not exactly sure where the credentials plugin adds the YUI buttons on top, but that's no longer needed, given the credentials plugin already utilizes the modernized buttons.
          New: The following scenario can be seen in locations, where you can add credentials through the credentials plugin.

          The "+ Add" button is a {{{}jenkins-button{}}}, as it should be, but its wrapped into a span adding {{yui-button}} on top of it, which displays two buttons, like we can see on the screenshot. The grey background is the hover effect of the jenkins-button and the blue frame is the hover effect of the yui-button.

          I'm not exactly sure where the credentials plugin adds the YUI buttons on top, but that's no longer needed, given the credentials plugin already utilizes the modernized buttons.
          Yen Cheng Lin made changes -
          Assignee New: Yen Cheng Lin [ ridemountainpig ]
          Yen Cheng Lin made changes -
          Assignee Original: Yen Cheng Lin [ ridemountainpig ]
          YI WEI HO made changes -
          Assignee New: YI WEI HO [ davidho0403 ]
          YI WEI HO made changes -
          Assignee Original: YI WEI HO [ davidho0403 ]
          YI WEI HO made changes -
          Assignee New: YI WEI HO [ davidho0403 ]
          YI WEI HO made changes -
          Assignee Original: YI WEI HO [ davidho0403 ]
          Yen Cheng Lin made changes -
          Assignee New: Yen Cheng Lin [ ridemountainpig ]
          Alexander Brandes made changes -
          Link New: This issue duplicates JENKINS-70215 [ JENKINS-70215 ]

            julieheard Julie Heard
            notmyfault Alexander Brandes
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: