Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-69549

Margins for headers and paragraphs make descriptions and non-trivial inline help look terrible since 2.320 + 2.335

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      Headers have significant bottom margins and no top margin per https://github.com/jenkinsci/jenkins/blob/04b46d1c68513e4a105b5acdfb7534c89da94eea/war/src/main/less/base/typography.less#L54-L55

      The last paragraph in a sequence (e.g. inside a wrapping div) has no bottom margin per https://github.com/jenkinsci/jenkins/blob/04b46d1c68513e4a105b5acdfb7534c89da94eea/war/src/main/less/base/style.less#L575-L578

      Headers should be closer to their related paragraphs than to unrelated content, that's not the case here. Especially the case of usage stats help look terrible, with no distance between a paragraph and an unrelated header. But even inline help, as well as basic HTML markup for descriptions, don't look good with these rules.

          [JENKINS-69549] Margins for headers and paragraphs make descriptions and non-trivial inline help look terrible since 2.320 + 2.335

          Daniel Beck created issue -
          Daniel Beck made changes -
          Description Original: Headers have significant bottom margins and no top margin per [https://github.com/jenkinsci/jenkins/blob/04b46d1c68513e4a105b5acdfb7534c89da94eea/war/src/main/less/base/typography.less#L54-L55]

          The last paragraph in a sequence (e.g. inside a wrapping div) has no bottom margin per [https://github.com/jenkinsci/jenkins/blob/04b46d1c68513e4a105b5acdfb7534c89da94eea/war/src/main/less/base/style.less#L575-L578]

          Headers should be closer to their related paragraphs than to unrelated content, that's not the case here. Especially the case of usage stats help look terrible, with no distance between a paragraph and an unrelated header.
          New: Headers have significant bottom margins and no top margin per [https://github.com/jenkinsci/jenkins/blob/04b46d1c68513e4a105b5acdfb7534c89da94eea/war/src/main/less/base/typography.less#L54-L55]

          The last paragraph in a sequence (e.g. inside a wrapping div) has no bottom margin per [https://github.com/jenkinsci/jenkins/blob/04b46d1c68513e4a105b5acdfb7534c89da94eea/war/src/main/less/base/style.less#L575-L578]

          Headers should be closer to their related paragraphs than to unrelated content, that's not the case here. Especially the case of usage stats help look terrible, with no distance between a paragraph and an unrelated header. But even inline help, as well as basic HTML markup for descriptions, don't look good with these rules.
          Daniel Beck made changes -
          Attachment New: Screenshot 2022-09-07 at 13.52.03.png [ 59027 ]
          Daniel Beck made changes -
          Summary Original: Margins for headers and paragraphs make non-trivial inline help look terrible New: Margins for headers and paragraphs make descriptions and non-trivial inline help look terrible
          frankie699 made changes -
          Assignee New: frankie699 [ frankie699 ]

          Basil Crow added a comment -

          This ticket does not have the last working release and first failing release, so I am adding the ux-untriaged label.

          Basil Crow added a comment - This ticket does not have the last working release and first failing release, so I am adding the ux-untriaged label.
          Basil Crow made changes -
          Labels Original: regression ux New: regression ux ux-untriaged
          Alexander Brandes made changes -
          Remote Link New: This issue links to "https://github.com/jenkinsci/jenkins/pull/7078 (Web Link)" [ 28215 ]
          Daniel Beck made changes -
          Summary Original: Margins for headers and paragraphs make descriptions and non-trivial inline help look terrible New: Margins for headers and paragraphs make descriptions and non-trivial inline help look terrible since 2.320 + 2.335
          Daniel Beck made changes -
          Labels Original: regression ux ux-untriaged New: regression ux

            frankie699 frankie699
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: