Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-69658

[junit] Un-inlining failed-test.jelly

XMLWordPrintable

      Level medium (due to lack of reproduction steps yet)
      Skills a bit of JavaScript, a bit of Jelly

      Culprit: failed-test.jelly#L38-L59

      UPDATE: the inline script was moved to an external file, but the onClick handlers are still inline.

      Reproduction steps:

      • missing

      Proposal

      Testing notes

      • Ensure to reproduce the feature before any change
      • Ensure that you reproduce the feature after you have made the change

          [JENKINS-69658] [junit] Un-inlining failed-test.jelly

          Wadeck Follonier created issue -
          Wadeck Follonier made changes -
          Assignee Original: Wadeck Follonier [ wfollonier ]
          Antoine Neveux made changes -
          Assignee New: Antoine Neveux [ aneveux ]
          Antoine Neveux made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Antoine Neveux made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]
          Antoine Neveux made changes -
          Assignee Original: Antoine Neveux [ aneveux ]
          Arthur CARON made changes -
          Assignee New: Arthur CARON [ lemomorse ]
          Kevin Guerroudj made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Kevin Guerroudj made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Wadeck Follonier made changes -
          Status Original: In Review [ 10005 ] New: In Progress [ 3 ]
          Wadeck Follonier made changes -
          Description Original: |Level|*medium* *(due to lack of reproduction steps yet)*|
          |Skills| a bit of JavaScript, a bit of Jelly|

          Culprit: [failed-test.jelly#L38-L59|https://github.com/jenkinsci/junit-plugin/blob/c9ef98e5f8927e2f381a58b4075d9919920993b4/src/main/resources/lib/hudson/test/failed-test.jelly#L38-L59]

          *Reproduction steps:*
          - (!) missing

          *Proposal*
          - Move the script block to an external file.
          - You can find such approach illustrated in https://github.com/jenkinsci/jenkins/pull/5786

          *Testing notes*
          - Ensure to reproduce the feature before any change
          - Ensure that you reproduce the feature after you have made the change

          		New: |Level|*medium* *(due to lack of reproduction steps yet)*|
          |Skills| a bit of JavaScript, a bit of Jelly|

          Culprit: [failed-test.jelly#L38-L59|https://github.com/jenkinsci/junit-plugin/blob/c9ef98e5f8927e2f381a58b4075d9919920993b4/src/main/resources/lib/hudson/test/failed-test.jelly#L38-L59]

          (!) UPDATE: the inline script was moved to an external file, but the onClick handlers are still inline.

          *Reproduction steps:*
          - (!) missing

          *Proposal*
          - Move the script block to an external file.
          - You can find such approach illustrated in https://github.com/jenkinsci/jenkins/pull/5786

          *Testing notes*
          - Ensure to reproduce the feature before any change
          - Ensure that you reproduce the feature after you have made the change

            shlomo_dahan Shlomo
            wfollonier Wadeck Follonier
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: