Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6966

Dependent plugins shows same description on installed page

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Installed plugins have the same description in the installed page as the plugins they depend on.

      e.g. ci-game, findbugs, and Static Analysis Collector Plug-in.
      screenshot attached.

      The details is on the IRC chat (dvaske, mindless and kohsuke) from [19:22:06]:
      http://echelog.matzon.dk/logs/browse/hudson/1278972000

          [JENKINS-6966] Dependent plugins shows same description on installed page

          dvaske created issue -

          dvaske added a comment -

          Major->minor issue.

          dvaske added a comment - Major->minor issue.
          dvaske made changes -
          Priority Original: Major [ 3 ] New: Minor [ 4 ]
          Alan Harder made changes -
          Assignee New: Alan Harder [ mindless ]
          Alan Harder made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/main/core/src/main/java/hudson/ClassicPluginStrategy.java
          trunk/hudson/main/core/src/main/java/hudson/PluginWrapper.java
          trunk/hudson/main/test/src/test/java/hudson/ClassicPluginStrategyTest.java
          trunk/hudson/main/test/src/test/resources/hudson/ClassicPluginStrategyTest/testDependencyClassLoader.zip
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/32876
          Log:
          [FIXED JENKINS-6966] Plugins with dependencies show wrong description on
          installed plugins page. DependencyClassLoader checks dependencies before
          this plugin, so wrong index.jelly is found for plugins with dependencies.
          Added implementation of findResources in DependencyClassLoader, and use
          getResources to find the right index.jelly in PluginWrapper.getIndexPage().

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/java/hudson/ClassicPluginStrategy.java trunk/hudson/main/core/src/main/java/hudson/PluginWrapper.java trunk/hudson/main/test/src/test/java/hudson/ClassicPluginStrategyTest.java trunk/hudson/main/test/src/test/resources/hudson/ClassicPluginStrategyTest/testDependencyClassLoader.zip trunk/www/changelog.html http://jenkins-ci.org/commit/32876 Log: [FIXED JENKINS-6966] Plugins with dependencies show wrong description on installed plugins page. DependencyClassLoader checks dependencies before this plugin, so wrong index.jelly is found for plugins with dependencies. Added implementation of findResources in DependencyClassLoader, and use getResources to find the right index.jelly in PluginWrapper.getIndexPage().
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          Ulli Hafner added a comment -

          Some plug-ins still have wrong texts, see screenshot.

          Ulli Hafner added a comment - Some plug-ins still have wrong texts, see screenshot.
          Ulli Hafner made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

          Ulli Hafner added a comment -

          First two entries have wrong text.

          Ulli Hafner added a comment - First two entries have wrong text.
          Ulli Hafner made changes -
          Attachment New: wrong-text.png [ 19624 ]

            mindless Alan Harder
            dvaske dvaske
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: