• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Component/s: core
• Labels:

  • ui
  • ux

[JENKINS-69734] Move <f:submit> to jenkins button classes

Alexander Brandes created issue - 2022-09-28 21:51

Alexander Brandes made changes - 2022-09-28 21:52

Description

Original: {{<f:submit}} wraps around legacy YUI buttons still, where a lot of individual buttons have been migrated to {{jenkins-button}}s already. https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/form/submit.jelly#L48 It would make sense to continue this process here, and move the class parameter from a {{primary}} button to a primary jenkins button, e.g., like https://weekly.ci.jenkins.io/design-library/Buttons/

New: {{<f:submit}} wraps around legacy YUI buttons still, where a lot of individual buttons have been migrated to {{jenkins-button}} s already. https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/form/submit.jelly#L48 It would make sense to continue this process here, and move the class parameter from a {{primary}} button to a primary jenkins button, e.g., like https://weekly.ci.jenkins.io/design-library/Buttons/

YI WEI HO made changes - 2022-10-07 19:18

Assignee

New: YI WEI HO [ davidho0403 ]

Alexander Brandes made changes - 2022-10-07 22:07

Summary

Original: Move <f:submit> from YUI buttons to jenkins-button

New: Move <f:submit> to jenkins button classes

Alexander Brandes made changes - 2022-10-07 22:08

Remote Link

New: This issue links to "https://github.com/jenkinsci/jenkins/pull/7203 (Web Link)" [ 28266 ]

Alexander Brandes made changes - 2022-10-07 22:08

Description

Original: {{<f:submit}} wraps around legacy YUI buttons still, where a lot of individual buttons have been migrated to {{jenkins-button}} s already. https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/form/submit.jelly#L48 It would make sense to continue this process here, and move the class parameter from a {{primary}} button to a primary jenkins button, e.g., like https://weekly.ci.jenkins.io/design-library/Buttons/

New: {{<f:submit}} wraps around legacy YUI buttons still, where a lot of individual buttons have been migrated to {{jenkins-button}} s already. It would make sense to continue this process here, and move the class parameter from a {{primary}} button to a primary jenkins button, e.g., like https://weekly.ci.jenkins.io/design-library/Buttons/

YI WEI HO made changes - 2022-10-08 04:08

Assignee

Original: YI WEI HO [ davidho0403 ]

Kayla Altepeter made changes - 2022-10-09 23:24

Assignee

New: Kayla Altepeter [ kaltepeter ]

Kayla Altepeter made changes - 2022-10-09 23:29

Assignee

Original: Kayla Altepeter [ kaltepeter ]

Alexander Brandes made changes - 2022-10-10 06:43

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Load more newer events