Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-69860

[jdk-tool] onclick usage DescriptorImpl/credentialOK.jelly

      Level easy
      Skills a bit of JavaScript, a bit of Jelly

      Culprit: https://github.com/jenkinsci/jdk-tool-plugin/blob/eef9873383a7ca7f01984f9ca5d0355911f8baec/src/main/resources/hudson/tools/JDKInstaller/DescriptorImpl/credentialOK.jelly#L31

      Reproduction steps:

      • Click on Close

      Screenshot attached about where the feature is displayed.

      NOTE: This is actually not working, recent browsers only allow scripts to close windows they opened

      Proposal
      https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

      Testing notes

      • Ensure to reproduce the feature before any change
      • Ensure that you reproduce the feature after you have made the change

          [JENKINS-69860] [jdk-tool] onclick usage DescriptorImpl/credentialOK.jelly

          Kevin Guerroudj created issue -
          Kevin Guerroudj made changes -
          Assignee Original: Wadeck Follonier [ wfollonier ]
          Kevin Guerroudj made changes -
          Description Original: |Level|*easy*|
          |Skills|a bit of JavaScript, a bit of Jelly|

          Culprit: [https://github.com/jenkinsci/jdk-tool-plugin/blob/eef9873383a7ca7f01984f9ca5d0355911f8baec/src/main/resources/hudson/tools/JDKInstaller/DescriptorImpl/credentialOK.jelly#L31]

          *Reproduction steps:*
           - Install [Oracle Java SE Development Kit Installer|https://plugins.jenkins.io/jdk-tool/] or clone [https://github.com/jenkinsci/jdk-tool-plugin] and then {{mvn hpi:run}}
           - Navigate to
          {noformat}
          [JENKINS_INSTANCE]/descriptorByName/hudson.tools.JDKInstaller/credentialOK
          {noformat}

           - Click on Close

          Screenshot attached about where the feature is displayed.

          (!) NOTE: This is actually not working, recent browsers only allow scripts to close windows they opened

          *Testing notes*
           - Ensure to reproduce the feature before any change
           - Ensure that you reproduce the feature after you have made the change
          New: |Level|*easy*|
          |Skills|a bit of JavaScript, a bit of Jelly|

          Culprit: [https://github.com/jenkinsci/jdk-tool-plugin/blob/eef9873383a7ca7f01984f9ca5d0355911f8baec/src/main/resources/hudson/tools/JDKInstaller/DescriptorImpl/credentialOK.jelly#L31]

          *Reproduction steps:*
           - Install [Oracle Java SE Development Kit Installer|https://plugins.jenkins.io/jdk-tool/] or clone [https://github.com/jenkinsci/jdk-tool-plugin] and then {{mvn hpi:run}}
           - Navigate to
          {noformat}
          [JENKINS_INSTANCE]/descriptorByName/hudson.tools.JDKInstaller/credentialOK
          {noformat}

           - Click on Close

          Screenshot attached about where the feature is displayed.

          (!) NOTE: This is actually not working, recent browsers only allow scripts to close windows they opened

          *Proposal*
          https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

          *Testing notes*
           - Ensure to reproduce the feature before any change
           - Ensure that you reproduce the feature after you have made the change
          Arthur CARON made changes -
          Assignee New: Arthur CARON [ lemomorse ]
          Arthur CARON made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Wadeck Follonier made changes -
          Component/s New: jdk-tool-plugin [ 23529 ]
          Component/s Original: strict-crumb-issuer-plugin [ 25631 ]
          Arthur CARON made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Arthur CARON made changes -
          Remote Link New: This issue links to "PR#47 (Web Link)" [ 28303 ]
          Arthur CARON made changes -
          Remote Link New: This issue links to "PR#48 (Web Link)" [ 28304 ]
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Fixed but Unreleased [ 10203 ]
          Jesse Glick made changes -
          Released As New: https://github.com/jenkinsci/jdk-tool-plugin/releases/tag/63.v62d2fd4b_4793
          Status Original: Fixed but Unreleased [ 10203 ] New: Resolved [ 5 ]

            lemomorse Arthur CARON
            kevingrdj Kevin Guerroudj
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: