[JENKINS-70351] GitHub Plugin settings not loaded on startup

Type: Bug
Resolution: Fixed
Priority: Minor
Component/s: github-plugin, support-core-plugin
Labels:
None
Environment:
github-plugin:1.36
jenkins:2.375.1

Similar Issues:
Powered by SuggestiMate

Show
Released As:
support-core:1241.v32a_39d7032e5

After upgrading GitHub Plugin to 1.36, global GitHub settings are not loaded upon restart. The following exception show up on restart:

2022-12-28 09:02:24.650+0000 [id=50]	WARNING	hudson.model.Descriptor#load: Failed to load /tmp/je-1-home/github-plugin-configuration.xml
com.thoughtworks.xstream.mapper.CannotResolveClassException: github-plugin-configuration
	at com.thoughtworks.xstream.mapper.DefaultMapper.realClass(DefaultMapper.java:81)
	at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:125)
	at com.thoughtworks.xstream.mapper.DynamicProxyMapper.realClass(DynamicProxyMapper.java:55)
	at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:125)
	at com.thoughtworks.xstream.mapper.PackageAliasingMapper.realClass(PackageAliasingMapper.java:88)
	at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:125)
	at com.thoughtworks.xstream.mapper.ClassAliasingMapper.realClass(ClassAliasingMapper.java:79)
	at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:125)
	at com.thoughtworks.xstream.mapper.ArrayMapper.realClass(ArrayMapper.java:74)
	at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:125)
	at com.thoughtworks.xstream.mapper.SecurityMapper.realClass(SecurityMapper.java:71)
	at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:125)
	at hudson.util.XStream2$CompatibilityMapper.realClass(XStream2.java:413)
	at hudson.util.xstream.MapperDelegate.realClass(MapperDelegate.java:46)
	at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:125)
	at com.thoughtworks.xstream.mapper.CachingMapper.realClass(CachingMapper.java:47)
	at com.thoughtworks.xstream.core.util.HierarchicalStreams.readClassType(HierarchicalStreams.java:29)
	at com.thoughtworks.xstream.core.TreeUnmarshaller.start(TreeUnmarshaller.java:135)
	at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.unmarshal(AbstractTreeMarshallingStrategy.java:32)
	at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1421)
	at hudson.util.XStream2.unmarshal(XStream2.java:190)
	at hudson.util.XStream2.unmarshal(XStream2.java:161)
	at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1399)
	at hudson.XmlFile.unmarshal(XmlFile.java:196)
Caused: java.io.IOException: Unable to read /tmp/je-1-home/github-plugin-configuration.xml
	at hudson.XmlFile.unmarshal(XmlFile.java:199)
	at hudson.XmlFile.unmarshal(XmlFile.java:179)
	at hudson.model.Descriptor.load(Descriptor.java:931)
	at org.jenkinsci.plugins.github.config.GitHubPluginConfig.<init>(GitHubPluginConfig.java:86)
	at org.jenkinsci.plugins.github.config.GitHubPluginConfig$$FastClassByGuice$$1235586272.GUICE$TRAMPOLINE(<generated>)
	at org.jenkinsci.plugins.github.config.GitHubPluginConfig$$FastClassByGuice$$1235586272.apply(<generated>)
	at com.google.inject.internal.DefaultConstructionProxyFactory$FastClassProxy.newInstance(DefaultConstructionProxyFactory.java:82)
	at com.google.inject.internal.ConstructorInjector.provision(ConstructorInjector.java:114)
	at com.google.inject.internal.ConstructorInjector.access$000(ConstructorInjector.java:33)
	at com.google.inject.internal.ConstructorInjector$1.call(ConstructorInjector.java:98)
	at com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:109)
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.onProvision(ExtensionFinder.java:568)
	at com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:117)
	at com.google.inject.internal.ProvisionListenerStackCallback.provision(ProvisionListenerStackCallback.java:66)
	at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:93)
	at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:296)
	at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
	at com.google.inject.internal.SingletonScope$1.get(SingletonScope.java:169)
	at hudson.ExtensionFinder$GuiceFinder$FaultTolerantScope$1.get(ExtensionFinder.java:444)
	at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:45)
	at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1100)
	at hudson.ExtensionFinder$GuiceFinder._find(ExtensionFinder.java:402)
	at hudson.ExtensionFinder$GuiceFinder.find(ExtensionFinder.java:393)
	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:359)
	at hudson.ExtensionList.load(ExtensionList.java:384)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:320)
	at hudson.ExtensionList.iterator(ExtensionList.java:172)
	at jenkins.model.Jenkins.getDescriptorByType(Jenkins.java:1642)
	at com.cloudbees.jenkins.support.impl.AbstractItemDirectoryComponent.getDescriptor(AbstractItemDirectoryComponent.java:96)
	at com.cloudbees.jenkins.support.impl.AbstractItemDirectoryComponent.getDescriptor(AbstractItemDirectoryComponent.java:30)
	at com.cloudbees.jenkins.support.impl.DirectoryComponent.<init>(DirectoryComponent.java:42)
	at com.cloudbees.jenkins.support.impl.AbstractItemDirectoryComponent.<init>(AbstractItemDirectoryComponent.java:34)
	at com.cloudbees.jenkins.support.impl.AbstractItemDirectoryComponent$$FastClassByGuice$$506053096.GUICE$TRAMPOLINE(<generated>)
	at com.cloudbees.jenkins.support.impl.AbstractItemDirectoryComponent$$FastClassByGuice$$506053096.apply(<generated>)
	at com.google.inject.internal.DefaultConstructionProxyFactory$FastClassProxy.newInstance(DefaultConstructionProxyFactory.java:82)
	at com.google.inject.internal.ConstructorInjector.provision(ConstructorInjector.java:114)
	at com.google.inject.internal.ConstructorInjector.access$000(ConstructorInjector.java:33)
	at com.google.inject.internal.ConstructorInjector$1.call(ConstructorInjector.java:98)
	at com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:109)
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.onProvision(ExtensionFinder.java:568)
	at com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:117)
	at com.google.inject.internal.ProvisionListenerStackCallback.provision(ProvisionListenerStackCallback.java:66)
	at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:93)
	at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:296)
	at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
	at com.google.inject.internal.SingletonScope$1.get(SingletonScope.java:169)
	at hudson.ExtensionFinder$GuiceFinder$FaultTolerantScope$1.get(ExtensionFinder.java:444)
	at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:45)
	at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1100)
	at hudson.ExtensionFinder$GuiceFinder._find(ExtensionFinder.java:402)
	at hudson.ExtensionFinder$GuiceFinder.find(ExtensionFinder.java:393)
	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:359)
	at hudson.ExtensionList.load(ExtensionList.java:384)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:320)
	at hudson.ExtensionList.iterator(ExtensionList.java:172)
	at java.base/java.util.Spliterators$IteratorSpliterator.estimateSize(Spliterators.java:1821)
	at java.base/java.util.Spliterator.getExactSizeIfKnown(Spliterator.java:408)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
	at com.cloudbees.jenkins.support.SupportPlugin.getComponents(SupportPlugin.java:291)
	at com.cloudbees.jenkins.support.SupportPlugin.postInitialize(SupportPlugin.java:654)
	at hudson.PluginManager$2$1$2.run(PluginManager.java:576)
	at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:177)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:305)
	at jenkins.model.Jenkins$5.runTask(Jenkins.java:1161)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:221)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:120)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:70)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

Downgrading GitHub plugin to 1.35 fixes this. So this is somehow related to https://github.com/jenkinsci/github-plugin/pull/304. That being said, maybe Support Core initialization must be assessed as well and need to use an @Initializer: https://github.com/jenkinsci/support-core-plugin/blob/1237.vdd0b_ed646870/src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java#L653-L671.

relates to

JENKINS-71786 Github Plugin configuration does not load after service restart

Reopened

links to

support-core-plugin #420

Allan BURDAJEWICZ created issue - 2022-12-28 09:13

Allan BURDAJEWICZ added a comment - 2022-12-28 09:14

cc rsandell

Allan BURDAJEWICZ added a comment - 2022-12-28 09:14 cc rsandell

Allan BURDAJEWICZ made changes - 2022-12-29 03:01

Assignee

Original: Kirill Merkushev [ lanwen ]

New: Allan BURDAJEWICZ [ allan_burdajewicz ]

Allan BURDAJEWICZ made changes - 2022-12-29 03:01

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Allan BURDAJEWICZ added a comment - 2022-12-29 03:01

This feels like a bug with Support Core. I am taking it.

Allan BURDAJEWICZ added a comment - 2022-12-29 03:01 This feels like a bug with Support Core. I am taking it.

Allan BURDAJEWICZ made changes - 2022-12-29 03:07

Remote Link

New: This issue links to "support-core-plugin #420 (Web Link)" [ 28418 ]

Allan BURDAJEWICZ made changes - 2022-12-29 03:07

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Allan BURDAJEWICZ made changes - 2022-12-29 09:49

Released As		New: support-core:1241.v32a_39d7032e5
Resolution		New: Fixed [ 1 ]
Status	Original: In Review [ 10005 ]	New: Resolved [ 5 ]

Jesse Glick made changes - 2024-08-16 17:26

Link

New: This issue relates to JENKINS-71786 [ JENKINS-71786 ]

Assignee:: Allan BURDAJEWICZ

Reporter:: Allan BURDAJEWICZ

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 2022-12-28 09:13

Updated:: 2024-08-16 17:26

Resolved:: 2022-12-29 09:49

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Allan BURDAJEWICZ added a comment - 2022-12-28 09:14

Expand comment: Allan BURDAJEWICZ added a comment - 2022-12-28 09:14

Collapse comment: Allan BURDAJEWICZ added a comment - 2022-12-29 03:01

Expand comment: Allan BURDAJEWICZ added a comment - 2022-12-29 03:01

People

Dates