Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-70529

[ldap] Un-inlining ldap/validate.jelly for CSP compatibility

      Level easy
      Skills a bit of JavaScript, a bit of Jelly

      Culprit:
      (1) - validation/validate.jelly#L58
      (2) - validation/validate.jelly#L71
      (3) - validation/validate.jelly#L83-L99

      Reproduction steps:

      • Install LDAP or clone https://github.com/jenkinsci/ldap-plugin and then mvn hpi:run
      • Go to Manage Jenkins > Configure Global Security
      • In the "Security Realm" section, select "LDAP"
      • Click on "Test LDAP settings" (1)
      • Click on "Test" (2)

      Screenshot attached about where the feature is displayed.

      Proposal
      https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers
      https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks

      Testing notes

      • Ensure to reproduce the feature before any change
      • Ensure that you reproduce the feature after you have made the change

        1. 3.png
          3.png
          59 kB
        2. 2.png
          2.png
          19 kB
        3. 1.png
          1.png
          42 kB

          [JENKINS-70529] [ldap] Un-inlining ldap/validate.jelly for CSP compatibility

          Kevin Guerroudj created issue -
          Kris Stern made changes -
          Assignee New: Kris Stern [ krisstern ]
          Neetigya made changes -
          Assignee Original: Kris Stern [ krisstern ] New: Neetigya [ neetigyapod ]
          Kevin Guerroudj made changes -
          Link New: This issue is duplicated by JENKINS-72117 [ JENKINS-72117 ]
          Kevin Guerroudj made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Kevin Guerroudj made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Kevin Guerroudj made changes -
          Remote Link New: This issue links to "PR-257 (Web Link)" [ 28976 ]
          Zbynek Konecny made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Closed [ 6 ]

            neetigyapod Neetigya
            kevingrdj Kevin Guerroudj
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: