Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7111

Timestamper plugin causes Mercurial update to fail?

    XMLWordPrintable

Details

    Description

      I'm seeing an odd issue with the Timestamper and the Mercurial plugins. The final steps of the Mercurial update fail like so:

      [test-framework] $ hg log --rev . --template {node}
      ERROR: Expected to get an id but got  instead.
      

      The hg log command works like that from the command line. It also worked before installing the Timestamper plugin. And, indeed, after disabling the Timestamper plugin, things start working again:

      [test-framework] $ hg log --rev . --template {node}
      [test-framework] $ /bin/sh -xe /var/tmp/hudson46154.sh
      (etc.)
      

      Not sure how exactly the Timestamper plugins injects the timestamp into the log. But it seems to interfere with the output that the Mercurial plugin expects.

      Attachments

        Issue Links

          Activity

            dhaun Dirk Haun created issue -
            StevenGBrown StevenGBrown made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            StevenGBrown StevenGBrown added a comment -

            Timestamper currently inserts timestamps into the output of any process started by the build's Launcher. The Mercurial plugin reads back this output and doesn't expect to see timestamps.

            I plan to implement a more robust approach soon, but it requires a change to Hudson core first.

            In the meantime, timestamping will be turned off during the SCM checkout.

            StevenGBrown StevenGBrown added a comment - Timestamper currently inserts timestamps into the output of any process started by the build's Launcher . The Mercurial plugin reads back this output and doesn't expect to see timestamps. I plan to implement a more robust approach soon, but it requires a change to Hudson core first. In the meantime, timestamping will be turned off during the SCM checkout.

            Code changed in hudson
            User: : StevenGBrown
            Path:
            trunk/hudson/plugins/timestamper/src/main/java/hudson/plugins/timestamper/TimestamperBuildWrapper.java
            http://jenkins-ci.org/commit/33481
            Log:
            [FIXED JENKINS-7111] timestamper-1.1: Timestamps are no longer inserted during the SCM checkout.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : StevenGBrown Path: trunk/hudson/plugins/timestamper/src/main/java/hudson/plugins/timestamper/TimestamperBuildWrapper.java http://jenkins-ci.org/commit/33481 Log: [FIXED JENKINS-7111] timestamper-1.1: Timestamps are no longer inserted during the SCM checkout.
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            StevenGBrown StevenGBrown added a comment -

            I plan to implement a more robust approach soon, but it requires a change to Hudson core first.

            See JENKINS-7112.

            StevenGBrown StevenGBrown added a comment - I plan to implement a more robust approach soon, but it requires a change to Hudson core first. See JENKINS-7112 .
            dhaun Dirk Haun added a comment -

            I'm still getting the same error with the Timestamper plugin 1.1. But I guess we'll simply wait for the solution in JENKINS-7112 ...

            dhaun Dirk Haun added a comment - I'm still getting the same error with the Timestamper plugin 1.1. But I guess we'll simply wait for the solution in JENKINS-7112 ...
            dhaun Dirk Haun made changes -
            Link This issue depends on JENKINS-7112 [ JENKINS-7112 ]
            vlatombe Vincent Latombe made changes -
            Link This issue is related to JENKINS-7811 [ JENKINS-7811 ]
            vlatombe Vincent Latombe made changes -
            Link This issue is related to JENKINS-7800 [ JENKINS-7800 ]
            abayer Andrew Bayer made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 137208 ] JNJira + In-Review [ 204425 ]

            People

              stevengbrown Steven G Brown
              dhaun Dirk Haun
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: