Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-71435

Unknown category unusable in Java Compiler Warnings

XMLWordPrintable

      Java compiler warnings that don't fall into a known category are inaccessible from the Categories view.

      We use a third party annotation processor that outputs its own compiler warnings. These warnings do show up under Packages and Files. However, when going to the Category tab, I just see a row with a blank value under the Category column, and there is no hyperlink so I can't view items in that category.

        1. Bildschirmfoto 2023-10-09 um 09.46.42.png
          Bildschirmfoto 2023-10-09 um 09.46.42.png
          91 kB

          [JENKINS-71435] Unknown category unusable in Java Compiler Warnings

          Ulli Hafner added a comment -

          Yes, it makes sense to replace empty categories or types with a "-" symbol. Then those warnings can be filtered by using a hyperlink.

          Ulli Hafner added a comment - Yes, it makes sense to replace empty categories or types with a "-" symbol. Then those warnings can be filtered by using a hyperlink.

          Senthil added a comment - - edited

          Hey drulli , I can understand the issue partially, but couldn't get it properly. Could you please explain whether issue to be solved, is it still opened? and what is the expected behaviour?

          Senthil added a comment - - edited Hey drulli , I can understand the issue partially, but couldn't get it properly. Could you please explain whether issue to be solved, is it still opened? and what is the expected behaviour?

          Ulli Hafner added a comment -

          The problem still exists, you can see here some warnings that do not have a category and therefore are shown without a link:

          Ulli Hafner added a comment - The problem still exists, you can see here some warnings that do not have a category and therefore are shown without a link:

          Ulli Hafner added a comment -

          This is the problematic code:

          https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/DetailsTableModel.java#L261

          Ulli Hafner added a comment - This is the problematic code: https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/DetailsTableModel.java#L261

          Jake added a comment -

          What kind of fix are we looking at drulli ? Or are we closing this?

          Do we want an "Uncategorized" or "Miscellaneous" Category?

          Jake added a comment - What kind of fix are we looking at drulli ? Or are we closing this? Do we want an "Uncategorized" or "Miscellaneous" Category?

          Ulli Hafner added a comment -

          Actually we just need something different than the empty string. I would suggest to replace empty string with "-" (because it is also used for packages and types), but it would work for "Uncategorized" or "Miscellaneous" as well.

          Ulli Hafner added a comment - Actually we just need something different than the empty string. I would suggest to replace empty string with "-" (because it is also used for packages and types), but it would work for "Uncategorized" or "Miscellaneous" as well.

          Jake added a comment -

          Alright!

          Jake added a comment - Alright!

          Jake added a comment - - edited

          Could the fix be here?

          https://github.com/jenkinsci/analysis-model/blob/cc4944568709b1330255efe3077f01c342751172/src/main/java/edu/hm/hafner/analysis/Issue.java#L567

          drulli 

          Jake added a comment - - edited Could the fix be here? https://github.com/jenkinsci/analysis-model/blob/cc4944568709b1330255efe3077f01c342751172/src/main/java/edu/hm/hafner/analysis/Issue.java#L567 drulli  

          Ulli Hafner added a comment - - edited

          No, the model is ok. Just the UI needs to changed, see comment from October (DetailsTableModel).

          Ulli Hafner added a comment - - edited No, the model is ok. Just the UI needs to changed, see comment from October (DetailsTableModel).

          Debayan added a comment -

          should I just change formatProperty such that if the rendered value is "" we represent with - or UNDEFINED?

          Debayan added a comment - should I just change formatProperty such that if the rendered value is "" we represent with - or UNDEFINED?

          Ulli Hafner added a comment -

          Yes, that should work.

          Ulli Hafner added a comment - Yes, that should work.

          Debayan added a comment -

          https://github.com/jenkinsci/warnings-ng-plugin/pull/1648 sent a pr for this issue

          Debayan added a comment - https://github.com/jenkinsci/warnings-ng-plugin/pull/1648 sent a pr for this issue

            debghosh666 Debayan
            jolemjake Jake
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: