-
Bug
-
Resolution: Fixed
-
Minor
-
None
-
-
2616.v07df00c08d42
Hi,
Took me a while to understand why tools were not installed on running agent even if the labels were set on the node.
I happen that the https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/tools/ToolInstaller.java#L87 doesn't consider assigned labels (Typically the ones created by LabelFinder extensions). Like https://github.com/jenkinsci/platformlabeler-plugin/blob/master/src/main/java/org/jvnet/hudson/plugins/platformlabeler/PlatformLabeler.java#L40
It's specially true of ephemeral agent and tool directive installation. Dynamic labels are assigned "too late" on the build.
I propose to change it to (not tested)
public boolean appliesTo(Node node) { Label l = Jenkins.get().getLabel(label); return l == null || node.getAssignedLabels().contains(l); }
Any thought ?
- links to
[JENKINS-72224] Labels view not refreshed when labels are added to a node (causing some time installer failure for ephemeral agents)
Component/s | New: platformlabeler-plugin [ 15650 ] |
Remote Link | New: This issue links to "PR (Web Link)" [ 28995 ] |
Component/s | Original: core [ 15593 ] |
Assignee | New: Valentin Delaye [ jonesbusy ] |
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
Released As | New: https://github.com/jenkinsci/platformlabeler-plugin/releases/tag/2287.va_d728a_42d7f1 | |
Resolution | New: Fixed [ 1 ] | |
Status | Original: In Review [ 10005 ] | New: Closed [ 6 ] |
Status | Original: Closed [ 6 ] | New: Fixed but Unreleased [ 10203 ] |
Status | Original: Fixed but Unreleased [ 10203 ] | New: Resolved [ 5 ] |
Released As | Original: https://github.com/jenkinsci/platformlabeler-plugin/releases/tag/2287.va_d728a_42d7f1 | New: 2287.va_d728a_42d7f1 |