• Type: Bug
• Resolution: Duplicate
• Priority: Minor
• Component/s: core
• Labels:

  • jenkins
  • performance
  • plugins
• Environment:

  Tested with update-center.json from https://updates.jenkins.io/dynamic-stable-2.414.1/update-center.json

1. 

   image-2023-12-19-11-07-48-046.png

   197 kB

   2023-12-19 10:07

[JENKINS-72438] High memory allocations when parsing update-center.json with json-lib-2.4-jenkins-3

Leon Schiesswald created issue - 2023-12-19 10:39

Leon Schiesswald made changes - 2023-12-19 10:40

Description

Original: We experienced high memory allocations when jenkins is trying to check for plugin updates. Our product showed increased allocations when parsing current 2.8MB update-center.json !image-2023-12-19-11-07-48-046.png|width=939,height=299! On prod instances this was about 170 GB of allocations within a minute.    I was able to reproduce it locally using IntellIJ profiler which showed about 80 GB of allocations when parsing update-center.json with the JsonTokener ([https://github.com/jenkinsci/json-lib/blob/master/src/main/jdk15/net/sf/json/JSONObject.java#L829)] culprit seems to be a null matcher which is recursively called and performs substring operations. [https://github.com/jenkinsci/json-lib/blob/master/src/main/java/net/sf/json/util/JSONTokener.java#L117]   Not sure how big the impact on this is or will be, just wanted to mention it here as this drove some of our (already close to memory limit) instances OOM.

New: We experienced high memory allocations when jenkins tried to check for plugin updates. Our product showed increased allocations when parsing current 2.8MB update-center.json !image-2023-12-19-11-07-48-046.png|width=939,height=299! On prod instances this was about 170 GB of allocations within a minute.    I was able to reproduce it locally using IntelliJ profiler which showed about 80 GB of allocations when parsing update-center.json with the JsonTokener ([https://github.com/jenkinsci/json-lib/blob/master/src/main/jdk15/net/sf/json/JSONObject.java#L829)] culprit seems to be a null matcher which is recursively called and performs substring operations. [https://github.com/jenkinsci/json-lib/blob/master/src/main/java/net/sf/json/util/JSONTokener.java#L117]   Not sure how big the impact on this is or will be, just wanted to mention it here as this drove some of our (already close to memory limit) instances OOM.

Mark Waite made changes - 2023-12-19 15:32

Component/s

Original: plugin-installation-manager-tool [ 25433 ]

Tim Jacomb made changes - 2023-12-27 22:14

Assignee

Original: Natasha Stopa [ stopalopa ]

Basil Crow made changes - 2024-04-25 19:50

Link

New: This issue duplicates JENKINS-67344 [ JENKINS-67344 ]

Basil Crow made changes - 2024-04-25 19:50

Resolution		New: Duplicate [ 3 ]
Status	Original: Open [ 1 ]	New: Closed [ 6 ]