• Type: New Feature
• Resolution: Fixed
• Priority: Minor
• Component/s: build-blocker-plugin
• Labels:

  None

1. 

   blocking1.PNG

   11 kB

   2024-04-19 03:05

2. 

   blocking2.PNG

   6 kB

   2024-04-19 03:05

3. 

   blocking3.PNG

   37 kB

   2024-04-19 03:05

4. 

   image-2024-04-19-05-04-00-587.png

   47 kB

   2024-04-19 03:04

5. 

   screenshot-1.png

   86 kB

   2024-04-04 19:47

[JENKINS-72588] Support for folder properties

Valentin Delaye created issue - 2024-01-22 09:30

Valentin Delaye made changes - 2024-01-22 09:34

Description

Original: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).] But I would like to setup such property at folder level for all jobs inherit the property by default. It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.  * Add optional dependency with folder plugin  * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]  ** Some code could be moved to an Abstract class  * Ensuring to retrieve property when querying getBuildBlockerProperty  * Tests

New: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).] But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.  * Add optional dependency with folder plugin  * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]  ** Some code could be moved to an Abstract class  * Ensuring to retrieve property when querying getBuildBlockerProperty  * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

Collapse comment: Denis Mone added a comment - 2024-01-28 20:37, Edited by Denis Mone - 2024-01-28 20:39

Denis Mone added a comment - 2024-01-28 20:37 - edited

Hello jonesbusy .
This seems like a useful feature for the plugin and I'd like to see it implemented.
The problem is that i am not familiar with Jenkins plugin development. I've only made 
some trivial code changes when i adopted the plugin.

Expand comment: Denis Mone added a comment - 2024-01-28 20:37, Edited by Denis Mone - 2024-01-28 20:39

Denis Mone added a comment - 2024-01-28 20:37 - edited Hello jonesbusy . This seems like a useful feature for the plugin and I'd like to see it implemented. The problem is that i am not familiar with Jenkins plugin development. I've only made  some trivial code changes when i adopted the plugin.

Valentin Delaye made changes - 2024-01-29 04:51

Description

Original: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).] But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.  * Add optional dependency with folder plugin  * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]  ** Some code could be moved to an Abstract class  * Ensuring to retrieve property when querying getBuildBlockerProperty  * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

New: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35|https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).] But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.  * Add optional dependency with folder plugin  * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java|https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]  ** Some code could be moved to an Abstract class  * Ensuring to retrieve property when querying getBuildBlockerProperty  * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

Valentin Delaye made changes - 2024-01-29 04:52

Description

Original: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35|https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).] But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.  * Add optional dependency with folder plugin  * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java|https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]  ** Some code could be moved to an Abstract class  * Ensuring to retrieve property when querying getBuildBlockerProperty  * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

New: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35|https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35] But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.  * Add optional dependency with folder plugin  * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java|https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java]  ** Some code could be moved to an Abstract class  * Ensuring to retrieve property when querying getBuildBlockerProperty  * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

Collapse comment: Valentin Delaye added a comment - 2024-01-29 05:01

Valentin Delaye added a comment - 2024-01-29 05:01

Hi,

That's ok, anyone is free to pick-up the issue (including me ). I would be very useful for me due to my setup where I want to enforce such property add folder level and not update hundreds of pipeline. For the moment I have other priorities and also wanted that JENKINS-72250 is resolved first.

Expand comment: Valentin Delaye added a comment - 2024-01-29 05:01

Valentin Delaye added a comment - 2024-01-29 05:01 Hi, That's ok, anyone is free to pick-up the issue (including me ). I would be very useful for me due to my setup where I want to enforce such property add folder level and not update hundreds of pipeline. For the moment I have other priorities and also wanted that JENKINS-72250 is resolved first.

Valentin Delaye made changes - 2024-03-31 05:25

Assignee

Original: Denis Mone [ dmone ]

New: Valentin Delaye [ jonesbusy ]

Valentin Delaye made changes - 2024-03-31 05:25

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Valentin Delaye made changes - 2024-03-31 08:03

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Collapse comment: Valentin Delaye added a comment - 2024-03-31 08:04

Valentin Delaye added a comment - 2024-03-31 08:04

dmone This is in review https://github.com/jenkinsci/build-blocker-plugin/pull/22

Can you take a look at it ? Regards,

Expand comment: Valentin Delaye added a comment - 2024-03-31 08:04

Valentin Delaye added a comment - 2024-03-31 08:04 dmone This is in review https://github.com/jenkinsci/build-blocker-plugin/pull/22 Can you take a look at it ? Regards,

Load more newer events