• Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Minor Minor
    • build-blocker-plugin
    • None
    • 165.v5ecb_fb_f61520

      blocking property support all jobs including pipeline (symbol was also added on https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35

      But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline

      It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.

       

        1. blocking1.PNG
          blocking1.PNG
          11 kB
        2. blocking2.PNG
          blocking2.PNG
          6 kB
        3. blocking3.PNG
          blocking3.PNG
          37 kB
        4. image-2024-04-19-05-04-00-587.png
          image-2024-04-19-05-04-00-587.png
          47 kB
        5. screenshot-1.png
          screenshot-1.png
          86 kB

          [JENKINS-72588] Support for folder properties

          Valentin Delaye created issue -
          Valentin Delaye made changes -
          Description Original: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).]

          But I would like to setup such property at folder level for all jobs inherit the property by default.

          It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.
           * Add optional dependency with folder plugin
           * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]
           ** Some code could be moved to an Abstract class
           * Ensuring to retrieve property when querying getBuildBlockerProperty
           * Tests

           
          New: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).]

          But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline

          It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.
           * Add optional dependency with folder plugin
           * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]
           ** Some code could be moved to an Abstract class
           * Ensuring to retrieve property when querying getBuildBlockerProperty
           * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

           
          Valentin Delaye made changes -
          Description Original: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).]

          But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline

          It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.
           * Add optional dependency with folder plugin
           * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]
           ** Some code could be moved to an Abstract class
           * Ensuring to retrieve property when querying getBuildBlockerProperty
           * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

           
          New: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35|https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).]

          But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline

          It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.
           * Add optional dependency with folder plugin
           * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java|https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]
           ** Some code could be moved to an Abstract class
           * Ensuring to retrieve property when querying getBuildBlockerProperty
           * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

           
          Valentin Delaye made changes -
          Description Original: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35|https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35).]

          But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline

          It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.
           * Add optional dependency with folder plugin
           * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java|https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java)]
           ** Some code could be moved to an Abstract class
           * Ensuring to retrieve property when querying getBuildBlockerProperty
           * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

           
          New: blocking property support all jobs including pipeline (symbol was also added on [https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35|https://github.com/jenkinsci/build-blocker-plugin/commit/c472151589710de894ff54a4ab278839b3280c35]

          But I would like to setup such property at folder level for all jobs inherit the property by default. Folder or multibranch pipeline

          It will avoid duplicating code at pipeline level and enforce such blocking status by person configuring job (like via JobDSL) and the ones implementing the pipeline.
           * Add optional dependency with folder plugin
           * Implement property implementing `FolderProperty` (example [https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java|https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionFolderProperty.java]
           ** Some code could be moved to an Abstract class
           * Ensuring to retrieve property when querying getBuildBlockerProperty
           * Tests. Ensure the property appear on the FolderPropertiesContext and not only the PropertiesContext

           
          Valentin Delaye made changes -
          Assignee Original: Denis Mone [ dmone ] New: Valentin Delaye [ jonesbusy ]
          Valentin Delaye made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Valentin Delaye made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Denis Mone made changes -
          Attachment New: screenshot-1.png [ 62421 ]
          Valentin Delaye made changes -
          Attachment New: image-2024-04-19-05-04-00-587.png [ 62463 ]
          Valentin Delaye made changes -
          Attachment New: blocking3.PNG [ 62464 ]
          Attachment New: blocking2.PNG [ 62465 ]
          Attachment New: blocking1.PNG [ 62466 ]
          Valentin Delaye made changes -
          Released As New: 165.v5ecb_fb_f61520
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            jonesbusy Valentin Delaye
            jonesbusy Valentin Delaye
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: