• Type: Bug
• Resolution: Unresolved
• Priority: Critical
• Component/s: versioncolumn-plugin
• Labels:

  None

[JENKINS-72688] "This node is offline because it uses an old agent.jar" error is misleading

Tzach Solomon created issue - 2024-02-08 20:27

Tzach Solomon made changes - 2024-02-08 20:27

Summary

Original: "This node is offline because it uses an old" is misleading

New: "This node is offline because it uses an old" error is misleading

Tzach Solomon made changes - 2024-02-08 20:28

Description

Original: Hi, The text "This node is offline because it uses an old" is misleading since the actual code is looking for the exact match, thus, the error should be "This node is offline because version needed is <VERSION>". <VERSION> of course should be version we compared to, usually the built-in version

New: Hi, The text "This node is offline because it uses an old" is misleading since the actual code is looking for the exact match, thus, the error should be "This node is offline because version needed is <VERSION>". <VERSION> of course should be version we compared to, usually the built-in version   Jenkins version: 2.332.3 versioncolumn-plugin: 2.2

Collapse comment: Mark Waite added a comment - 2024-02-08 20:50, Edited by Mark Waite - 2024-02-08 22:53

Mark Waite added a comment - 2024-02-08 20:50 - edited

To be sure that I understand the request, I think that you are saying that the existing message that says "Making <agent> offline temporarily due to the use of an old agent.jar" should instead say something like "Making <agent> offline temporarily due to the use of an agent.jar version <version> instead of the expected version <version>".

If so, then I think this would be better solved by JENKINS-63607 which proposes to accept newer versions of Jenkins remoting without a message.

Expand comment: Mark Waite added a comment - 2024-02-08 20:50, Edited by Mark Waite - 2024-02-08 22:53

Mark Waite added a comment - 2024-02-08 20:50 - edited To be sure that I understand the request, I think that you are saying that the existing message that says "Making <agent> offline temporarily due to the use of an old agent.jar" should instead say something like "Making <agent> offline temporarily due to the use of an agent.jar version <version> instead of the expected version <version>". If so, then I think this would be better solved by JENKINS-63607 which proposes to accept newer versions of Jenkins remoting without a message.

Mark Waite made changes - 2024-02-08 22:53

Summary

Original: "This node is offline because it uses an old" error is misleading

New: "This node is offline because it uses an old agent.jar" error is misleading

Mark Waite made changes - 2024-02-09 11:03

Link

New: This issue is related to JENKINS-63607 [ JENKINS-63607 ]

Collapse comment: Tzach Solomon added a comment - 2024-02-10 18:22

Tzach Solomon added a comment - 2024-02-10 18:22

markewaite thanks for the quick response!

1. Yes, the more generic solution should be in JENKINS-63607
2. In the short term I think its a quick win to change the text, if you could do it would be great, If not, i'll to submit a PR ASAP

Expand comment: Tzach Solomon added a comment - 2024-02-10 18:22

Tzach Solomon added a comment - 2024-02-10 18:22 markewaite thanks for the quick response! Yes, the more generic solution should be in JENKINS-63607 In the short term I think its a quick win to change the text, if you could do it would be great, If not, i'll to submit a PR ASAP

Collapse comment: Mark Waite added a comment - 2024-02-10 18:37

Mark Waite added a comment - 2024-02-10 18:37

You're welcome to submit the text change.

Expand comment: Mark Waite added a comment - 2024-02-10 18:37

Mark Waite added a comment - 2024-02-10 18:37 You're welcome to submit the text change.