• Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • _unsorted
    • None

      Since Jetty 12 doesn't support mutable MIME types, I have deprecated this field in https://github.com/jenkinsci/jenkins-test-harness/pull/764. The field should just be deleted, but before we can delete it, we need to remove the sole remaining usage in https://github.com/jenkinsci/kubernetes-pipeline-plugin/blob/master/core/src/test/java/org/jvnet/hudson/test/JenkinsRuleNonLocalhost.java#L71 as in https://github.com/jenkinsci/kubernetes-plugin/pull/1547. (I am also aware of a proprietary usage in LowThreadsJenkinsRule in cloudbees-support-plugin.) Once that is done, the field should be deleted from jenkins-test-harness, and the temporary changes made to it in the prototype branch of jenkins-test-harness should be undone.

          [JENKINS-73124] Remove MIME types from test harness

          Basil Crow created issue -
          Basil Crow made changes -
          Link New: This issue is blocking JENKINS-73125 [ JENKINS-73125 ]
          Basil Crow made changes -
          Description Original: Since Jetty 12 doesn't support mutable MIME types, I have deprecated in https://github.com/jenkinsci/jenkins-test-harness/pull/764. This field should just be deleted, but before we can delete it, we need to remove the sole remaining usage in https://github.com/jenkinsci/kubernetes-pipeline-plugin/blob/master/core/src/test/java/org/jvnet/hudson/test/JenkinsRuleNonLocalhost.java#L71 as in https://github.com/jenkinsci/kubernetes-plugin/pull/1547. (I am also aware of a proprietary usage in {{LowThreadsJenkinsRule}} in {{cloudbees-support-plugin}}.) Once that is done, the field should be deleted from {{jenkins-test-harness}}, and the temporary changes made to it in the {{prototype}} branch of {{jenkins-test-harness}} should be undone. New: Since Jetty 12 doesn't support mutable MIME types, I have deprecated this field in [https://github.com/jenkinsci/jenkins-test-harness/pull/764]. The field should just be deleted, but before we can delete it, we need to remove the sole remaining usage in [https://github.com/jenkinsci/kubernetes-pipeline-plugin/blob/master/core/src/test/java/org/jvnet/hudson/test/JenkinsRuleNonLocalhost.java#L71] as in [https://github.com/jenkinsci/kubernetes-plugin/pull/1547]. (I am also aware of a proprietary usage in {{LowThreadsJenkinsRule}} in {{{}cloudbees-support-plugin{}}}.) Once that is done, the field should be deleted from {{{}jenkins-test-harness{}}}, and the temporary changes made to it in the {{prototype}} branch of {{jenkins-test-harness}} should be undone.
          Adrien Lecharpentier made changes -
          Assignee New: Adrien Lecharpentier [ alecharp ]
          Adrien Lecharpentier made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Adrien Lecharpentier made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          I filled a pull request to remove the method usage.
          But the plugin is using a very old Parent POM version, thus won't get the jenkins-test-harness version which will remove the method.

          Shouldn't it be safe to remove the field / method from JTH?

          Adrien Lecharpentier added a comment - I filled a pull request to remove the method usage. But the plugin is using a very old Parent POM version, thus won't get the jenkins-test-harness version which will remove the method. Shouldn't it be safe to remove the field / method from JTH?

          Basil Crow added a comment -

          Basil Crow added a comment - I have completed this task in https://github.com/jenkinsci/jenkins-test-harness/pull/774 .
          Basil Crow made changes -
          Assignee Original: Adrien Lecharpentier [ alecharp ] New: Basil Crow [ basil ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Closed [ 6 ]

            basil Basil Crow
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: