Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73245

OS verification performed applies to Controller instead of Node

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • msbuild-plugin

      MsBuildInstaller#checkOsIsWindows is checking the os.name java property ; however (unless I'm wrong) this executes on the controller and not on the node.

      Setups with a Linux controller and Windows agents do not work and automatic installation of MSbuild fails with "MSBuild is only available on Windows" even though the job is running on a Windows agent. 

          [JENKINS-73245] OS verification performed applies to Controller instead of Node

          Benoit created issue -
          Benoit made changes -
          Description Original: [MsBuildInstaller#checkOsIsWindows|https://github.com/jenkinsci/msbuild-plugin/blob/master/src/main/java/hudson/plugins/msbuild/MsBuildInstaller.java#L262] is checking os.name ; however (unless I'm wrong) this executes on the controller and not on the node.

          Setups with a Linux controller and Windows agents do not work and automatic installation of MSbuild fails with "MSBuild is only available on Windows" even though the job is running on a Windows agent.            		New: [MsBuildInstaller#checkOsIsWindows|https://github.com/jenkinsci/msbuild-plugin/blob/96ea58c2f273bb6508d00dda90c95071bb50798e/src/main/java/hudson/plugins/msbuild/MsBuildInstaller.java#L262] is checking the {{os.name}} java property ; however (unless I'm wrong) this executes on the controller and not on the node.

          Setups with a Linux controller and Windows agents do not work and automatic installation of MSbuild fails with "MSBuild is only available on Windows" even though the job is running on a Windows agent. 
          Tilo made changes -
          Assignee Original: Lionel Cabasson [ marshall777 ] New: Tilo [ tilalx ]

          Tilo added a comment - - edited

          I'll look into this issue

          Tilo added a comment - - edited I'll look into this issue
          Tilo made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Tilo made changes -
          Released As New: msbuild-1.33
          Labels New: bug
          Tilo made changes -
          Released As Original: msbuild-1.33 New: https://github.com/jenkinsci/msbuild-plugin/releases/tag/msbuild-1.33

          Tilo added a comment -

          Resolved in version 1.33. Please let me know if it works for you now.

          Tilo added a comment - Resolved in version 1.33. Please let me know if it works for you now.
          Tilo made changes -
          Assignee Original: Tilo [ tilalx ] New: Benjamin Zaiser [ ben ]
          Tilo made changes -
          Assignee Original: Benjamin Zaiser [ ben ] New: Benoit [ bendardenne ]

            bendardenne Benoit
            bendardenne Benoit
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: