Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73247

Adapt Git plugin for Jetty 12 (EE 9) or remove Mockito usages from GitStatusTest

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major Major
    • git-plugin
    • None

      When a Jetty 12 EE 9 core (i.e., one built from the jakarta branch of jenkins) and Jetty 12 EE 9 compatible test harness (i.e., one built from the forward branch of jenkins-test-harness) are used, the following test fails:

      • hudson.plugins.git.GitStatusTest

      One solution is e.g. https://github.com/jenkinsci/git-plugin/pull/1589 to migrate to using Mockito with Jetty 12 EE 9. Unfortunately, that approach is not backward compatible with Jetty 10 or Jetty 12 EE 8, so the PR will have to remain in draft until we release Jetty 12 EE 9 support. Still, we should prepare the PR in advance.

      Alternatively, it would be more desirable if this test could instead stop using Mockito as in https://github.com/jenkinsci/view-job-filters-plugin/pull/58 and https://github.com/jenkinsci/configuration-as-code-plugin/pull/2494. That change could be prepared and released in advance without updating this plugin's core baseline.

          [JENKINS-73247] Adapt Git plugin for Jetty 12 (EE 9) or remove Mockito usages from GitStatusTest

          Basil Crow created issue -
          Mark Waite made changes -
          Assignee Original: Mark Waite [ markewaite ]
          Basil Crow made changes -
          Summary Original: Remove Mockito usages from GitStatusTest New: Adapt Git plugin for Jetty 12 (EE 9) or remove Mockito usages from GitStatusTest
          Basil Crow made changes -
          Description Original: While [https://github.com/jenkinsci/git-plugin/pull/1589] proves that EE 9 can be supported using Mockito, that PR relies on the first EE 9 weekly release and thus must remain in draft form. It would be more desirable if this test could instead stop using Mockito as in [https://github.com/jenkinsci/view-job-filters-plugin/pull/58] and https://github.com/jenkinsci/configuration-as-code-plugin/pull/2494.

          CC [~markewaite] 
          New: When a Jetty 12 EE 9 core (i.e., one built from the {{jakarta}} branch of {{jenkins}}) and Jetty 12 EE 9 compatible test harness (i.e., one built from the {{forward}} branch of {{jenkins-test-harness}}) are used, the following test fails:

          * {{hudson.plugins.git.GitStatusTest}}

          One solution is e.g. [https://github.com/jenkinsci/git-plugin/pull/1589] to migrate to using Mockito with Jetty 12 EE 9. Unfortunately, that approach is not backward compatible with Jetty 10 or Jetty 12 EE 8, so the PR will have to remain in draft until we release Jetty 12 EE 9 support. Still, we should prepare the PR in advance.

          Alternatively, it would be more desirable if this test could instead stop using Mockito as in [https://github.com/jenkinsci/view-job-filters-plugin/pull/58] and [https://github.com/jenkinsci/configuration-as-code-plugin/pull/2494]. That change could be prepared and released in advance without updating this plugin's core baseline.
          Basil Crow made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          Basil Crow made changes -
          Epic Link New: JENKINS-73255 [ 221250 ]
          Basil Crow made changes -
          Link New: This issue is blocking JENKINS-73283 [ JENKINS-73283 ]
          Basil Crow made changes -
          Issue Type Original: Bug [ 1 ] New: Task [ 3 ]
          Basil Crow made changes -
          Link New: This issue depends on JENKINS-73278 [ JENKINS-73278 ]
          Basil Crow made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

            markewaite Mark Waite
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: