• Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • ec2-plugin
    • None

      Update the EC2 plugin to use the AWS SDK for Java 2.x as provided by the AWS SDK for Java 2.x API plugin

      Confirm that the EC2 plugin works as expected.

          [JENKINS-73640] Update EC2 plugin to use AWS SDK for Java 2.x

          Mark Waite created issue -
          Mark Waite made changes -
          Link New: This issue is blocked by JENKINS-73639 [ JENKINS-73639 ]
          Mark Waite made changes -
          Summary Original: Update Amazon EC2 plugin to use AWS SDK for Java 2.x New: Update EC2 plugin to use AWS SDK for Java 2.x
          Mark Waite made changes -
          Rank New: Ranked higher

          Basil Crow added a comment -

          ec2-cloud-axis depends on this plugin, so care should be taken to preserve compatibility.

          Basil Crow added a comment - ec2-cloud-axis depends on this plugin, so care should be taken to preserve compatibility.

          Denis Blanchette added a comment - - edited

          I've started work on this. I'm at a point where there are no compilation errors, but some tests fail. For example, CASC configurations are broken because the name of the enums are different for isntance types.

          I'm not sure I'll have time to finish this, but you are welcome to start from where I left of

          I pushed my changes here: 

          https://github.com/coveord/ec2-plugin/tree/feat/aws-sdk-v2

          Denis Blanchette added a comment - - edited I've started work on this. I'm at a point where there are no compilation errors, but some tests fail. For example, CASC configurations are broken because the name of the enums are different for isntance types. I'm not sure I'll have time to finish this, but you are welcome to start from where I left of I pushed my changes here:  https://github.com/coveord/ec2-plugin/tree/feat/aws-sdk-v2

          Basil Crow added a comment -

          Thanks for starting this, dblanchette! I did a little more work on this today and got all the tests passing in https://github.com/jenkinsci/ec2-plugin/pull/1021 by adjusting the CasC tests to expect the new enumeration names. This obviously needs to be improved to be backward-compatible with the old enumeration names before the change can be released, but in the meantime it gives us an incremental build at https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/ec2/1791.vf0f35ec30a_fe/ (Plugin Installation Manager input format: ec2:incrementals;org.jenkins-ci.plugins;1791.vf0f35ec30a_fe) which can be installed as described in https://www.jenkins.io/doc/book/managing/plugins/#advanced-installation for testing purposes. It would be great if you or anyone else could try running that against a real EC2 environment and fix up any remaining problems that are encountered.

          Basil Crow added a comment - Thanks for starting this, dblanchette ! I did a little more work on this today and got all the tests passing in https://github.com/jenkinsci/ec2-plugin/pull/1021 by adjusting the CasC tests to expect the new enumeration names. This obviously needs to be improved to be backward-compatible with the old enumeration names before the change can be released, but in the meantime it gives us an incremental build at https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/ec2/1791.vf0f35ec30a_fe/ (Plugin Installation Manager input format: ec2:incrementals;org.jenkins-ci.plugins;1791.vf0f35ec30a_fe ) which can be installed as described in https://www.jenkins.io/doc/book/managing/plugins/#advanced-installation for testing purposes. It would be great if you or anyone else could try running that against a real EC2 environment and fix up any remaining problems that are encountered.

          Basil Crow added a comment -

          (I also wonder if there might be a compatibility issue with serialized XStream XML data that contains old instance type enumeration values.)

          Basil Crow added a comment - (I also wonder if there might be a compatibility issue with serialized XStream XML data that contains old instance type enumeration values.)
          Basil Crow made changes -
          Remote Link New: This issue links to "jenkinsci/ec2-plugin#1021 (Web Link)" [ 30427 ]
          Basil Crow made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

            Unassigned Unassigned
            markewaite Mark Waite
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated: