-
Bug
-
Resolution: Fixed
-
Minor
-
None
I am writing unit tests for my Jenkins pipelines, involving some custom logic for retrieving/handling the coverage results. For this, I rely on the coverage-model module:
dependencies {
// ...
implementation 'edu.hm.hafner:coverage-model:0.46.0'
// ...
}
Using
import edu.hm.hafner.coverage.Coverage.CoverageBuilder
now to implement something similar to the original pipeline with
private Optional<Value> convertToCoverage(final Fraction fraction, final Metric metric) { return Optional.ofNullable( new CoverageBuilder().withMetric(metric) .withCovered(fraction.getNumerator()) .withTotal(fraction.getDenominator()) .build() ) }
I am observing issues about edu.hm.hafner.util.Ensure not being available. The Gradle dependency tree does not report a suitable dependency as well.
Trying to find a standalone package for this turned out to not be easy: I could either use codingstyle-pom which does not seem to make much sense for a standalone use case or retrieve my own copy from either https://github.com/uhafner/codingstyle/blob/main/src/main/java/edu/hm/hafner/util/Ensure.java or https://github.com/uhafner/config/blob/master/src/main/java/edu/hm/hafner/util/Ensure.java, which does not feel correct either and introduces further dependencies which do not seem to be necessary.
At the moment, I am using a local copy of Ensure.java without external dependencies, but this does not feel correct. In my opinion, edu.hm.hafner.util should be distributed as a regular package for further re-use to allow clean library usage.
[JENKINS-73663] Dependencies are missing in released artifact
Stefan
created issue -
Stefan
made changes -
| Description |
Original:
I am writing unit tests for my Jenkins pipelines, involving some custom logic for retrieving/handling the coverage results. For this, I rely on the _coverage-model_ module:
{code:java} dependencies { // ... implementation 'edu.hm.hafner:coverage-model:0.46.0' // ... }{code} Using {code:java} import edu.hm.hafner.coverage.Coverage.CoverageBuilder{code} now to implement something similar to the original pipeline with {code:java} private Optional<Value> convertToCoverage(final Fraction fraction, final Metric metric) { return Optional.ofNullable( new CoverageBuilder().withMetric(metric) .withCovered(fraction.getNumerator()) .withTotal(fraction.getDenominator()) .build() ) }{code} I am observing issues about _edu.hm.hafner.util.Ensure_ not being available. The Gradle dependency tree does not report a suitable dependency as well. Trying to find a standalone package for this turned out to not be easy: I could either use _codingstyle-pom_ which does not seem to make much sense for a standalone use case or retrieve my own copy from either [https://github.com/uhafner/codingstyle/blob/main/src/main/java/edu/hm/hafner/util/Ensure.java] or [https://github.com/uhafner/config/blob/master/src/main/java/edu/hm/hafner/util/Ensure.java], which does not feel correct either and introduces further dependencies which do not seem to be necessary. At the moment, I am using a local copy of _Ensure.java_ without external dependencies, but this does not feel correct. In my opinion, _edu.hm.hafner.util_ should be distributed as a regular package for further re-use to allow clean library usage. |
New:
I am writing unit tests for my Jenkins pipelines, involving some custom logic for retrieving/handling the coverage results. For this, I rely on the _coverage-model_ module:
{code:java} dependencies { // ... implementation 'edu.hm.hafner:coverage-model:0.46.0' // ... }{code} Using {code:java} import edu.hm.hafner.coverage.Coverage.CoverageBuilder{code} now to implement something similar to the original pipeline with {code:java} private Optional<Value> convertToCoverage(final Fraction fraction, final Metric metric) { return Optional.ofNullable( new CoverageBuilder().withMetric(metric) .withCovered(fraction.getNumerator()) .withTotal(fraction.getDenominator()) .build() ) }{code} I am observing issues about _edu.hm.hafner.util.Ensure_ not being available. The Gradle dependency tree does not report a suitable dependency as well. Trying to find a standalone package for this turned out to not be easy: I could either use _codingstyle-pom_ which does not seem to make much sense for a standalone use case or retrieve my own copy from either [https://github.com/uhafner/codingstyle/blob/main/src/main/java/edu/hm/hafner/util/Ensure.java] or [https://github.com/uhafner/config/blob/master/src/main/java/edu/hm/hafner/util/Ensure.java], which does not feel correct either and introduces further dependencies which do not seem to be necessary. At the moment, I am using a local copy of _Ensure.java_ without external dependencies, but this does not feel correct. In my opinion, _edu.hm.hafner.util_ should be distributed as a regular package for further re-use to allow clean library usage. |
It does not seem to be the case. I have added a very basic example project at https://github.com/stefan6419846/JENKINS-73663 which does not define any source sets, but where running ./gradlew dependencies shows that coverage-model does not seem to have any dependencies in Gradle, while the Groovy dependency has dependencies (see dependencies.txt):
... | +--- org.apache.groovy:groovy-xml:4.0.22 | | +--- org.apache.groovy:groovy-bom:4.0.22 (*) | | \--- org.apache.groovy:groovy:4.0.22 (*) | \--- org.apache.groovy:groovy-yaml:4.0.22 | +--- org.apache.groovy:groovy-bom:4.0.22 (*) | \--- org.apache.groovy:groovy:4.0.22 (*) \--- edu.hm.hafner:coverage-model:0.46.0
There clearly are no references to codingstyle, although I am not sure why.
Just for the record (not shown in the above example): I had to declare the dependency on commons-lang3 manually as well:
implementation 'org.apache.commons:commons-lang3:3.16.0'
Stefan
added a comment - - edited It does not seem to be the case. I have added a very basic example project at https://github.com/stefan6419846/JENKINS-73663 which does not define any source sets, but where running ./gradlew dependencies shows that coverage-model does not seem to have any dependencies in Gradle, while the Groovy dependency has dependencies (see dependencies.txt ):
...
| +--- org.apache.groovy:groovy-xml:4.0.22
| | +--- org.apache.groovy:groovy-bom:4.0.22 (*)
| | \--- org.apache.groovy:groovy:4.0.22 (*)
| \--- org.apache.groovy:groovy-yaml:4.0.22
| +--- org.apache.groovy:groovy-bom:4.0.22 (*)
| \--- org.apache.groovy:groovy:4.0.22 (*)
\--- edu.hm.hafner:coverage-model:0.46.0
There clearly are no references to codingstyle , although I am not sure why.
Just for the record (not shown in the above example): I had to declare the dependency on commons-lang3 manually as well:
implementation 'org.apache.commons:commons-lang3:3.16.0'
| Component/s | New: coverage-model [ 29124 ] | |
| Component/s | Original: coverage-plugin [ 29223 ] |
| Summary | Original: coverage-model: Provide clean implementation of edu.hm.hafner.util | New: Dependencies are missing in released artifact |
| Issue Type | Original: New Feature [ 2 ] | New: Bug [ 1 ] |
You are right, I just checked https://central.sonatype.com/artifact/edu.hm.hafner/coverage-model/0.46.0/versions and all dependencies seem to be removed in the deployed artifact. Somehow I broke the pom.xml structrure during the release process...
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Remote Link | New: This issue links to "coverage-model PR #122 (Web Link)" [ 29980 ] |
Does Gadle not pick up the transitive dependencies? In Maven I get: