-
Story
-
Resolution: Fixed
-
Minor
-
None
The GitSCMExtension decorates the GitClient first and then it set the credentials if a credentials ID is provided https://github.com/jenkinsci/git-plugin/blob/git-5.2.2/src/main/java/hudson/plugins/git/GitSCM.java#L929. This behavior was changed a long long time ago though I am not convinced it was intentional https://github.com/jenkinsci/git-plugin/commit/5bbee1ffbfbfe16441b5b5ac09bb2b32fa6fae63.
Maybe the GitClient should be initialized first (credentials included) and GitSCMExtension at the end.
Noticed this particular behavior when working on a bug fix for Bitbucket Branch Source that implements an interesting extension to pass the credentials ID: https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/888.v8e6d479a_1730/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/GitClientAuthenticatorExtension.java.
- blocks
-
JENKINS-73471 Git scm.userRemoteConfigs.credentialsId configured by Bitbucket is null
-
- Closed
-
- is blocked by
-
JENKINS-73797 Git checkout of Bitbucket multibranch Pipelines fails when using ssh
-
- Resolved
-
[JENKINS-73677] Initialize GitClient credentials before decorating it with extensions
Description |
Original:
The {{GitSCMExtension}} decorates the {{GitClient}} first and then it set the credentials if a credentials ID is provided https://github.com/jenkinsci/git-plugin/blob/git-5.2.2/src/main/java/hudson/plugins/git/GitSCM.java#L929.
This behavior was changed a long long time ago though I am not convinced it was intentional https://github.com/jenkinsci/git-plugin/commit/5bbee1ffbfbfe16441b5b5ac09bb2b32fa6fae63. I think that maybe the {{GitClient}} should be initialized first (credentials included) and {{GitSCMExtension}} at the end. Noticed this particular behavior when working on a bug fix for Bitbucket Branch Source that implements an interesting extension to pass the credentials ID: https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/888.v8e6d479a_1730/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/GitClientAuthenticatorExtension.java. |
New:
The {{GitSCMExtension}} decorates the {{GitClient}} first and then it set the credentials if a credentials ID is provided https://github.com/jenkinsci/git-plugin/blob/git-5.2.2/src/main/java/hudson/plugins/git/GitSCM.java#L929. This behavior was changed a long long time ago though I am not convinced it was intentional https://github.com/jenkinsci/git-plugin/commit/5bbee1ffbfbfe16441b5b5ac09bb2b32fa6fae63.
Maybe the {{GitClient}} should be initialized first (credentials included) and {{GitSCMExtension}} at the end. Noticed this particular behavior when working on a bug fix for Bitbucket Branch Source that implements an interesting extension to pass the credentials ID: https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/888.v8e6d479a_1730/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/GitClientAuthenticatorExtension.java. |
Assignee | Original: Mark Waite [ markewaite ] | New: Allan BURDAJEWICZ [ allan_burdajewicz ] |
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
Resolution | New: Fixed [ 1 ] | |
Status | Original: In Review [ 10005 ] | New: Fixed but Unreleased [ 10203 ] |
Released As | New: https://github.com/jenkinsci/git-plugin/releases/tag/git-5.5.0 | |
Status | Original: Fixed but Unreleased [ 10203 ] | New: Closed [ 6 ] |
Link |
New:
This issue is blocked by |
Resolution | Original: Fixed [ 1 ] | |
Status | Original: Closed [ 6 ] | New: Reopened [ 4 ] |
Link |
New:
This issue blocks |
Resolution | New: Fixed [ 1 ] | |
Status | Original: Reopened [ 4 ] | New: Fixed but Unreleased [ 10203 ] |