Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73687

Make deserialization of Map fields in XML files more robust

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Accidental serial compatibility mistakes like the one described in https://github.com/jenkinsci/hashicorp-vault-plugin/issues/326 should be limited in extent to the closest surrounding RobustFooConverter, which should report the warning to OldDataMonitor but otherwise ignore the broken element and continue deserialization normally.

      In that issue, a mistake involving a Map field in a folder property lead to the folder itself being corrupted in a way that caused further problems, which we would like to avoid.

      https://github.com/jenkinsci/jenkins/pull/9653 proposes a change to RobustMapConverter which would have limited the impact of this kind of mistake.

          [JENKINS-73687] Make deserialization of Map fields in XML files more robust

          Devin Nusbaum created issue -
          Devin Nusbaum made changes -
          Remote Link New: This issue links to "jenkinsci/jenkins#9653 (Web Link)" [ 29947 ]
          Devin Nusbaum made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Devin Nusbaum made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Devin Nusbaum made changes -
          Link New: This issue relates to JENKINS-49169 [ JENKINS-49169 ]
          Devin Nusbaum made changes -
          Issue Type Original: Improvement [ 4 ] New: Bug [ 1 ]
          Devin Nusbaum made changes -
          Description Original: Accidental serial compatibility mistakes like the one described in [https://github.com/jenkinsci/hashicorp-vault-plugin/issues/326] should be limited in extent to the closest surrounding {{RobustFooConverter}}, which should report the warning to {{OldDataMonitor}} but otherwise ignore the broken element and continue deserialization normally.

          In that issue, a mistake involving a {{Map}} field in a folder property lead to the folder itself being corrupted in a way that caused further problems, which we would like to avoid.

          https://github.com/jenkinsci/jenkins/pull/9653 proposes a change which would have limited the impact of this kind of mistake.
          New: Accidental serial compatibility mistakes like the one described in [https://github.com/jenkinsci/hashicorp-vault-plugin/issues/326] should be limited in extent to the closest surrounding {{RobustFooConverter}}, which should report the warning to {{OldDataMonitor}} but otherwise ignore the broken element and continue deserialization normally.

          In that issue, a mistake involving a {{Map}} field in a folder property lead to the folder itself being corrupted in a way that caused further problems, which we would like to avoid.

          https://github.com/jenkinsci/jenkins/pull/9653 proposes a change to {{RobustMapConverter}} which would have limited the impact of this kind of mistake.
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-63343 [ JENKINS-63343 ]
          Mark Waite made changes -
          Released As New: https://www.jenkins.io/changelog/2.477/
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            dnusbaum Devin Nusbaum
            dnusbaum Devin Nusbaum
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: