[JENKINS-74032] [jobConfigHistory] Extract inline script blocks and event handlers in hudson/plugins/jobConfigHistory/ComputerConfigHistoryAction/showDiffFiles.jelly

Type: Task
Resolution: Fixed
Priority: Minor
Component/s: jobconfighistory-plugin
Labels:
- CSP

Similar Issues:
Powered by SuggestiMate

Show
Epic Link:
CSP compatibility for Jenkins plugins
Released As:
1283.veb_dfb_00b_5ec0

Problems

== Inline Script Block
Line: 11
----
<script>hljs.initHighlightingOnLoad();</script>
----

== Inline Script Block
Line: 65
----
<script>
                var showVersionDiffsJs = true;

                function toggleShowHideVersionDiffsJs(hideText, showText) {
                  showVersionDiffsJs = !showVersionDiffsJs;
                  if (showVersionDiffsJs === true) {
                    document.getElementById("tbody_versionDiffsShown").style.display = '';
                    document.getElementById("tbody_versionDiffsHidden").style.display = 'none';

                    document.getElementById("showHideVersionDiffsJsButton").value = hideText;
                  } else {
                    document.getElementById("tbody_versionDiffsShown").style.display = 'none';
                    document.getElementById("tbody_versionDiffsHidden").style.display = '';

                    document.getElementById("showHideVersionDiffsJsButton").value = showText;
                  }
                }
              </script>
----

== Inline Event Handler
Line: 87
----
<input id="showHideVersionDiffsJsButton" class="small-button" type="button" value="${%Hide Version Changes}" onClick="toggleShowHideVersionDiffsJs('${hideTextStr}', '${showTextStr}');"/>

Solutions

https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

links to

jenkinsci/job-config-history-plugin/pull/343

Basil Crow created issue - 2024-10-23 23:11

Basil Crow made changes - 2024-10-24 00:46

Summary

Original: [jobConfigHistory] Extract inline script blocks and lsevent handlers in hudson/plugins/jobConfigHistory/ComputerConfigHistoryAction/showDiffFiles.jelly

New: [jobConfigHistory] Extract inline script blocks and event handlers in hudson/plugins/jobConfigHistory/ComputerConfigHistoryAction/showDiffFiles.jelly

Yaroslav Afenkin made changes - 2024-10-24 11:15

Assignee

New: Yaroslav Afenkin [ yafenkin ]

Yaroslav Afenkin made changes - 2024-10-24 12:44

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Yaroslav Afenkin made changes - 2024-10-24 12:44

Description

Original: h4. Problems

{noformat}
== Inline Script Block
Line: 11
----
<script>hljs.initHighlightingOnLoad();</script>
----

== Inline Script Block
Line: 65
----
<script>
                var showVersionDiffsJs = true;

                function toggleShowHideVersionDiffsJs(hideText, showText) {
                  showVersionDiffsJs = !showVersionDiffsJs;
                  if (showVersionDiffsJs === true) {
                    document.getElementById("tbody_versionDiffsShown").style.display = '';
                    document.getElementById("tbody_versionDiffsHidden").style.display = 'none';

                    document.getElementById("showHideVersionDiffsJsButton").value = hideText;
                  } else {
                    document.getElementById("tbody_versionDiffsShown").style.display = 'none';
                    document.getElementById("tbody_versionDiffsHidden").style.display = '';

                    document.getElementById("showHideVersionDiffsJsButton").value = showText;
                  }
                }
              </script>
----

== Inline Event Handler
Line: 87
----
<input id="showHideVersionDiffsJsButton" class="small-button" type="button" value="${%Hide Version Changes}" onClick="toggleShowHideVersionDiffsJs('${hideTextStr}', '${showTextStr}');"/>
----

== Inline Script Block
Line: 11
----
<script>hljs.initHighlightingOnLoad();</script>
----

== Inline Script Block
Line: 65
----
<script>
                var showVersionDiffsJs = true;

                function toggleShowHideVersionDiffsJs(hideText, showText) {
                  showVersionDiffsJs = !showVersionDiffsJs;
                  if (showVersionDiffsJs === true) {
                    document.getElementById("tbody_versionDiffsShown").style.display = '';
                    document.getElementById("tbody_versionDiffsHidden").style.display = 'none';

                    document.getElementById("showHideVersionDiffsJsButton").value = hideText;
                  } else {
                    document.getElementById("tbody_versionDiffsShown").style.display = 'none';
                    document.getElementById("tbody_versionDiffsHidden").style.display = '';

                    document.getElementById("showHideVersionDiffsJsButton").value = showText;
                  }
                }
              </script>
----

== Inline Event Handler
Line: 87
----
<input id="showHideVersionDiffsJsButton" class="small-button" type="button" value="${%Hide Version Changes}" onClick="toggleShowHideVersionDiffsJs('${hideTextStr}', '${showTextStr}');"/>
----
{noformat}

h4. Solutions

[https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
[https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]

New: h4. Problems

{noformat}
== Inline Script Block
Line: 11
----
<script>hljs.initHighlightingOnLoad();</script>
----

== Inline Script Block
Line: 65
----
<script>
                var showVersionDiffsJs = true;

                function toggleShowHideVersionDiffsJs(hideText, showText) {
                  showVersionDiffsJs = !showVersionDiffsJs;
                  if (showVersionDiffsJs === true) {
                    document.getElementById("tbody_versionDiffsShown").style.display = '';
                    document.getElementById("tbody_versionDiffsHidden").style.display = 'none';

                    document.getElementById("showHideVersionDiffsJsButton").value = hideText;
                  } else {
                    document.getElementById("tbody_versionDiffsShown").style.display = 'none';
                    document.getElementById("tbody_versionDiffsHidden").style.display = '';

                    document.getElementById("showHideVersionDiffsJsButton").value = showText;
                  }
                }
              </script>
----

== Inline Event Handler
Line: 87
----
<input id="showHideVersionDiffsJsButton" class="small-button" type="button" value="${%Hide Version Changes}" onClick="toggleShowHideVersionDiffsJs('${hideTextStr}', '${showTextStr}');"/>
{noformat}

h4. Solutions

[https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
[https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]

Yaroslav Afenkin made changes - 2024-10-24 13:07

Remote Link

New: This issue links to "jenkinsci/job-config-history-plugin/pull/343 (Web Link)" [ 30103 ]

Yaroslav Afenkin made changes - 2024-10-24 13:07

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Basil Crow added a comment - 2024-10-29 19:14

Fixed in jenkinsci/job-config-history-plugin#343. Released in 1283.veb_dfb_00b_5ec0.

Basil Crow added a comment - 2024-10-29 19:14 Fixed in jenkinsci/job-config-history-plugin#343 . Released in 1283.veb_dfb_00b_5ec0 .

Basil Crow made changes - 2024-10-29 19:14

Released As		New: 1283.veb_dfb_00b_5ec0
Resolution		New: Fixed [ 1 ]
Status	Original: In Review [ 10005 ]	New: Closed [ 6 ]

Assignee:: Yaroslav Afenkin

Reporter:: Basil Crow

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Created:: 2024-10-23 23:11

Updated:: 2024-10-29 19:14

Resolved:: 2024-10-29 19:14

Jenkins

Details

Description

Problems

Solutions

Attachments

Issue Links

Activity

Collapse comment: Basil Crow added a comment - 2024-10-29 19:14

Expand comment: Basil Crow added a comment - 2024-10-29 19:14

People

Dates