Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74036

[active-directory] Extract inline script block in hudson/plugins/active_directory/ActiveDirectoryStatus/index.jelly

XMLWordPrintable

    • 2.38

      Problem

      == Inline Script Block
Line: 74
----
<script>
                function display(r) {
                    r.domainHealth.forEach(function(domainHealth) {
                        var tr = document.createElement('tr');
                        var td1 = document.createElement('td');
                        var td2 = document.createElement('td');
                        var td3 = document.createElement('td');
                        var td4 = document.createElement('td');
                        var text1 = document.createTextNode(domainHealth.host + ' / ' + domainHealth.ipAddress);
                        var text2 = document.createTextNode(domainHealth.canLogin);
                        var text3 = document.createTextNode(domainHealth.pingExecutionTime + ' ms');
                        var text4 = document.createTextNode(domainHealth.loginExecutionTime  + ' ms');
                        td1.appendChild(text1);
                        td2.appendChild(text2);
                        td3.appendChild(text3);
                        td4.appendChild(text4);
                        tr.appendChild(td1);
                        tr.appendChild(td2);
                        tr.appendChild(td3);
                        tr.appendChild(td4);
                        document.getElementById("demo").appendChild(tr);
                    });
                }
            </script>
----

      Solution

      https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks

          [JENKINS-74036] [active-directory] Extract inline script block in hudson/plugins/active_directory/ActiveDirectoryStatus/index.jelly

          Basil Crow created issue -
          Basil Crow made changes -
          Assignee Original: Félix Belzunce Arcos [ fbelzunc ]
          Basil Crow made changes -
          Description Original: h4. Problems

          {noformat}
          == Inline Script Block
          Line: 74
          ----
          <script>
                          function display(r) {
                              r.domainHealth.forEach(function(domainHealth) {
                                  var tr = document.createElement('tr');
                                  var td1 = document.createElement('td');
                                  var td2 = document.createElement('td');
                                  var td3 = document.createElement('td');
                                  var td4 = document.createElement('td');
                                  var text1 = document.createTextNode(domainHealth.host + ' / ' + domainHealth.ipAddress);
                                  var text2 = document.createTextNode(domainHealth.canLogin);
                                  var text3 = document.createTextNode(domainHealth.pingExecutionTime + ' ms');
                                  var text4 = document.createTextNode(domainHealth.loginExecutionTime + ' ms');
                                  td1.appendChild(text1);
                                  td2.appendChild(text2);
                                  td3.appendChild(text3);
                                  td4.appendChild(text4);
                                  tr.appendChild(td1);
                                  tr.appendChild(td2);
                                  tr.appendChild(td3);
                                  tr.appendChild(td4);
                                  document.getElementById("demo").appendChild(tr);
                              });
                          }
                      </script>
          ----

          == Inline Script Block
          Line: 74
          ----
          <script>
                          function display(r) {
                              r.domainHealth.forEach(function(domainHealth) {
                                  var tr = document.createElement('tr');
                                  var td1 = document.createElement('td');
                                  var td2 = document.createElement('td');
                                  var td3 = document.createElement('td');
                                  var td4 = document.createElement('td');
                                  var text1 = document.createTextNode(domainHealth.host + ' / ' + domainHealth.ipAddress);
                                  var text2 = document.createTextNode(domainHealth.canLogin);
                                  var text3 = document.createTextNode(domainHealth.pingExecutionTime + ' ms');
                                  var text4 = document.createTextNode(domainHealth.loginExecutionTime + ' ms');
                                  td1.appendChild(text1);
                                  td2.appendChild(text2);
                                  td3.appendChild(text3);
                                  td4.appendChild(text4);
                                  tr.appendChild(td1);
                                  tr.appendChild(td2);
                                  tr.appendChild(td3);
                                  tr.appendChild(td4);
                                  document.getElementById("demo").appendChild(tr);
                              });
                          }
                      </script>
          ----
          {noformat}

          h4. Solution

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          		 New: h4. Problem

          {noformat}
          == Inline Script Block
          Line: 74
          ----
          <script>
                          function display(r) {
                              r.domainHealth.forEach(function(domainHealth) {
                                  var tr = document.createElement('tr');
                                  var td1 = document.createElement('td');
                                  var td2 = document.createElement('td');
                                  var td3 = document.createElement('td');
                                  var td4 = document.createElement('td');
                                  var text1 = document.createTextNode(domainHealth.host + ' / ' + domainHealth.ipAddress);
                                  var text2 = document.createTextNode(domainHealth.canLogin);
                                  var text3 = document.createTextNode(domainHealth.pingExecutionTime + ' ms');
                                  var text4 = document.createTextNode(domainHealth.loginExecutionTime + ' ms');
                                  td1.appendChild(text1);
                                  td2.appendChild(text2);
                                  td3.appendChild(text3);
                                  td4.appendChild(text4);
                                  tr.appendChild(td1);
                                  tr.appendChild(td2);
                                  tr.appendChild(td3);
                                  tr.appendChild(td4);
                                  document.getElementById("demo").appendChild(tr);
                              });
                          }
                      </script>
          ----
          {noformat}

          h4. Solution

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          Summary Original: [active-directory] Extract inline script blocks in hudson/plugins/active_directory/ActiveDirectoryStatus/index.jelly New: [active-directory] Extract inline script block in hudson/plugins/active_directory/ActiveDirectoryStatus/index.jelly
          Yaroslav Afenkin made changes -
          Assignee New: Yaroslav Afenkin [ yafenkin ]
          Yaroslav Afenkin made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Yaroslav Afenkin made changes -
          Remote Link New: This issue links to "jenkinsci/active-directory-plugin/pull/209 (Web Link)" [ 30126 ]
          Yaroslav Afenkin made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Yaroslav Afenkin made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Fixed but Unreleased [ 10203 ]

          Basil Crow added a comment -

          Fixed in jenkinsci/active-directory-plugin#209. Released in 2.38.

          Basil Crow added a comment - Fixed in jenkinsci/active-directory-plugin#209 . Released in 2.38 .
          Basil Crow made changes -
          Released As New: 2.38
          Status Original: Fixed but Unreleased [ 10203 ] New: Closed [ 6 ]

            yafenkin Yaroslav Afenkin
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: