-
Task
-
Resolution: Unresolved
-
Minor
Problems
== Inline Script Block
Line: 26
----
<script>
function updateWorkspaceSpec() {
var inst = <st:bind value="${instance}"/>;
var name = document.getElementById("id.name").value;
inst.getSpecJSON(name, function(t) {
var json = t.responseObject();
document.getElementById("id.allwrite").checked = json.options.allwrite;
document.getElementById("id.clobber").checked = json.options.clobber;
document.getElementById("id.compress").checked = json.options.compress;
document.getElementById("id.locked").checked = json.options.locked;
document.getElementById("id.modtime").checked = json.options.modtime;
document.getElementById("id.rmdir").checked = json.options.rmdir;
document.getElementById("id.stream").value = json.stream;
document.getElementById("id.line").value = json.line;
document.getElementById("id.view").value = json.view;
});
}
</script>
----
== Inline Event Handler
Line: 10
----
<!--f:textbox id="id.name" onfocus="updateWorkspaceSpec()" onkeyup="updateWorkspaceSpec()" /-->
----
Solutions
https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers
- links to
[JENKINS-74091] [p4] Extract inline script block and event handler in org/jenkinsci/plugins/p4/workspace/ManualWorkspaceImpl/config.jelly
Basil Crow
created issue -
Basil Crow
made changes -
| Summary | Original: [p4] Extract inline script blocks and lsevent handlers in org/jenkinsci/plugins/p4/workspace/ManualWorkspaceImpl/config.jelly | New: [p4] Extract inline script blocks and event handlers in org/jenkinsci/plugins/p4/workspace/ManualWorkspaceImpl/config.jelly |
Basil Crow
made changes -
| Description |
Original:
h4. Problems {noformat} == Inline Script Block Line: 26 ---- <script> function updateWorkspaceSpec() { var inst = <st:bind value="${instance}"/>; var name = document.getElementById("id.name").value; inst.getSpecJSON(name, function(t) { var json = t.responseObject(); document.getElementById("id.allwrite").checked = json.options.allwrite; document.getElementById("id.clobber").checked = json.options.clobber; document.getElementById("id.compress").checked = json.options.compress; document.getElementById("id.locked").checked = json.options.locked; document.getElementById("id.modtime").checked = json.options.modtime; document.getElementById("id.rmdir").checked = json.options.rmdir; document.getElementById("id.stream").value = json.stream; document.getElementById("id.line").value = json.line; document.getElementById("id.view").value = json.view; }); } </script> ---- == Inline Event Handler Line: 10 ---- <!--f:textbox id="id.name" onfocus="updateWorkspaceSpec()" onkeyup="updateWorkspaceSpec()" /--> ---- == Inline Script Block Line: 26 ---- <script> function updateWorkspaceSpec() { var inst = <st:bind value="${instance}"/>; var name = document.getElementById("id.name").value; inst.getSpecJSON(name, function(t) { var json = t.responseObject(); document.getElementById("id.allwrite").checked = json.options.allwrite; document.getElementById("id.clobber").checked = json.options.clobber; document.getElementById("id.compress").checked = json.options.compress; document.getElementById("id.locked").checked = json.options.locked; document.getElementById("id.modtime").checked = json.options.modtime; document.getElementById("id.rmdir").checked = json.options.rmdir; document.getElementById("id.stream").value = json.stream; document.getElementById("id.line").value = json.line; document.getElementById("id.view").value = json.view; }); } </script> ---- == Inline Event Handler Line: 10 ---- <!--f:textbox id="id.name" onfocus="updateWorkspaceSpec()" onkeyup="updateWorkspaceSpec()" /--> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers] |
New:
h4. Problems {noformat} == Inline Script Block Line: 26 ---- <script> function updateWorkspaceSpec() { var inst = <st:bind value="${instance}"/>; var name = document.getElementById("id.name").value; inst.getSpecJSON(name, function(t) { var json = t.responseObject(); document.getElementById("id.allwrite").checked = json.options.allwrite; document.getElementById("id.clobber").checked = json.options.clobber; document.getElementById("id.compress").checked = json.options.compress; document.getElementById("id.locked").checked = json.options.locked; document.getElementById("id.modtime").checked = json.options.modtime; document.getElementById("id.rmdir").checked = json.options.rmdir; document.getElementById("id.stream").value = json.stream; document.getElementById("id.line").value = json.line; document.getElementById("id.view").value = json.view; }); } </script> ---- == Inline Event Handler Line: 10 ---- <!--f:textbox id="id.name" onfocus="updateWorkspaceSpec()" onkeyup="updateWorkspaceSpec()" /--> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers] |
| Summary | Original: [p4] Extract inline script blocks and event handlers in org/jenkinsci/plugins/p4/workspace/ManualWorkspaceImpl/config.jelly | New: [p4] Extract inline script block and event handler in org/jenkinsci/plugins/p4/workspace/ManualWorkspaceImpl/config.jelly |
Yaroslav Afenkin
made changes -
| Assignee | New: Yaroslav Afenkin [ yafenkin ] |
Yaroslav Afenkin
made changes -
| Assignee | Original: Yaroslav Afenkin [ yafenkin ] |
Yaroslav Afenkin
made changes -
| Assignee | New: Yaroslav Afenkin [ yafenkin ] |
Yaroslav Afenkin
made changes -
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Yaroslav Afenkin
made changes -
| Remote Link | New: This issue links to "jenkinsci/p4-plugin/pull/218 (Web Link)" [ 30243 ] |
Yaroslav Afenkin
made changes -
| Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
