Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74100

[gitlab-logo] Extract inline script block and event handler in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly

XMLWordPrintable

    • 130.v9d2696eb_8dc6

      Problems

      == Inline Script Block
Line: 25
----
<script>
      var GitlabLogoProperty = {
        clearCache: function(){
          fetch("${rootURL}/descriptor/org.jenkinsci.plugins.gitlablogo.GitlabLogoProperty/clearCache", {
            method: "post",
            headers: crumb.wrap({}),
          }).then((rsp) => {
            if (rsp.ok) {
              alert("Clear cache done");
            }
          });
        }
      };
    </script>
----

== Inline Event Handler
Line: 23
----
<input type="button" value="clear" onclick="GitlabLogoProperty.clearCache();"/>
----

      Solutions

      https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
      https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

          [JENKINS-74100] [gitlab-logo] Extract inline script block and event handler in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly

          Basil Crow created issue -
          Basil Crow made changes -
          Summary Original: [gitlab-logo] Extract inline script blocks and lsevent handlers in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly New: [gitlab-logo] Extract inline script blocks and event handlers in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly
          Basil Crow made changes -
          Assignee Original: sue445 [ sue445 ]
          Basil Crow made changes -
          Description Original: h4. Problems

          {noformat}
          == Inline Script Block
          Line: 25
          ----
          <script>
                var GitlabLogoProperty = {
                  clearCache: function(){
                    fetch("${rootURL}/descriptor/org.jenkinsci.plugins.gitlablogo.GitlabLogoProperty/clearCache", {
                      method: "post",
                      headers: crumb.wrap({}),
                    }).then((rsp) => {
                      if (rsp.ok) {
                        alert("Clear cache done");
                      }
                    });
                  }
                };
              </script>
          ----

          == Inline Event Handler
          Line: 23
          ----
          <input type="button" value="clear" onclick="GitlabLogoProperty.clearCache();"/>
          ----

          == Inline Script Block
          Line: 25
          ----
          <script>
                var GitlabLogoProperty = {
                  clearCache: function(){
                    fetch("${rootURL}/descriptor/org.jenkinsci.plugins.gitlablogo.GitlabLogoProperty/clearCache", {
                      method: "post",
                      headers: crumb.wrap({}),
                    }).then((rsp) => {
                      if (rsp.ok) {
                        alert("Clear cache done");
                      }
                    });
                  }
                };
              </script>
          ----

          == Inline Event Handler
          Line: 23
          ----
          <input type="button" value="clear" onclick="GitlabLogoProperty.clearCache();"/>
          ----
          {noformat}

          h4. Solutions

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          		 New: h4. Problems

          {noformat}
          == Inline Script Block
          Line: 25
          ----
          <script>
                var GitlabLogoProperty = {
                  clearCache: function(){
                    fetch("${rootURL}/descriptor/org.jenkinsci.plugins.gitlablogo.GitlabLogoProperty/clearCache", {
                      method: "post",
                      headers: crumb.wrap({}),
                    }).then((rsp) => {
                      if (rsp.ok) {
                        alert("Clear cache done");
                      }
                    });
                  }
                };
              </script>
          ----

          == Inline Event Handler
          Line: 23
          ----
          <input type="button" value="clear" onclick="GitlabLogoProperty.clearCache();"/>
          ----
          {noformat}

          h4. Solutions

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          Summary Original: [gitlab-logo] Extract inline script blocks and event handlers in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly New: [gitlab-logo] Extract inline script block and event handler in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly
          Yaroslav Afenkin made changes -
          Assignee New: Yaroslav Afenkin [ yafenkin ]
          Yaroslav Afenkin made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Yaroslav Afenkin made changes -
          Remote Link New: This issue links to "jenkinsci/gitlab-logo-plugin/pull/80 (Web Link)" [ 30227 ]
          Yaroslav Afenkin made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          Basil Crow added a comment -

          Fixed in jenkinsci/gitlab-logo-plugin#80. Released in 130.v9d2696eb_8dc6.

          Basil Crow added a comment - Fixed in jenkinsci/gitlab-logo-plugin#80 . Released in 130.v9d2696eb_8dc6 .
          Basil Crow made changes -
          Released As New: 130.v9d2696eb_8dc6
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Closed [ 6 ]

            yafenkin Yaroslav Afenkin
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: