• Type: Task
• Resolution: Fixed
• Priority: Minor
• Component/s: gitlab-logo-plugin
• Labels:

  • CSP

[JENKINS-74100] [gitlab-logo] Extract inline script block and event handler in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly

Basil Crow created issue - 2024-10-23 23:18

Basil Crow made changes - 2024-10-24 00:47

Summary

Original: [gitlab-logo] Extract inline script blocks and lsevent handlers in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly

New: [gitlab-logo] Extract inline script blocks and event handlers in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly

Basil Crow made changes - 2024-10-24 00:47

Assignee

Original: sue445 [ sue445 ]

Basil Crow made changes - 2024-10-24 14:51

Description	Original: h4. Problems {noformat} == Inline Script Block Line: 25 ---- <script>       var GitlabLogoProperty = {         clearCache: function(){           fetch("${rootURL}/descriptor/org.jenkinsci.plugins.gitlablogo.GitlabLogoProperty/clearCache", {             method: "post",             headers: crumb.wrap({}),           }).then((rsp) => {             if (rsp.ok) {               alert("Clear cache done");             }           });         }       };     </script> ---- == Inline Event Handler Line: 23 ---- <input type="button" value="clear" onclick="GitlabLogoProperty.clearCache();"/> ---- == Inline Script Block Line: 25 ---- <script>       var GitlabLogoProperty = {         clearCache: function(){           fetch("${rootURL}/descriptor/org.jenkinsci.plugins.gitlablogo.GitlabLogoProperty/clearCache", {             method: "post",             headers: crumb.wrap({}),           }).then((rsp) => {             if (rsp.ok) {               alert("Clear cache done");             }           });         }       };     </script> ---- == Inline Event Handler Line: 23 ---- <input type="button" value="clear" onclick="GitlabLogoProperty.clearCache();"/> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]	New: h4. Problems {noformat} == Inline Script Block Line: 25 ---- <script>       var GitlabLogoProperty = {         clearCache: function(){           fetch("${rootURL}/descriptor/org.jenkinsci.plugins.gitlablogo.GitlabLogoProperty/clearCache", {             method: "post",             headers: crumb.wrap({}),           }).then((rsp) => {             if (rsp.ok) {               alert("Clear cache done");             }           });         }       };     </script> ---- == Inline Event Handler Line: 23 ---- <input type="button" value="clear" onclick="GitlabLogoProperty.clearCache();"/> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
Summary	Original: [gitlab-logo] Extract inline script blocks and event handlers in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly	New: [gitlab-logo] Extract inline script block and event handler in org/jenkinsci/plugins/gitlablogo/GitlabLogoProperty/global.jelly

Yaroslav Afenkin made changes - 2024-11-19 08:53

Assignee

New: Yaroslav Afenkin [ yafenkin ]

Yaroslav Afenkin made changes - 2024-11-19 09:00

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Yaroslav Afenkin made changes - 2024-11-19 10:48

Remote Link

New: This issue links to "jenkinsci/gitlab-logo-plugin/pull/80 (Web Link)" [ 30227 ]

Yaroslav Afenkin made changes - 2024-11-19 10:58

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Basil Crow made changes - 2024-11-19 18:27

Released As		New: 130.v9d2696eb_8dc6
Resolution		New: Fixed [ 1 ]
Status	Original: In Review [ 10005 ]	New: Closed [ 6 ]