Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74109

[claim] Extract inline script block and event handlers in hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • claim-plugin
    • 585.v619f52a_a_09dc

      Problems

      == Inline Script Block
      Line: 5
      ----
      <script type="text/javascript">
                      function ShowPopup(hoveritem) {
                      var row = hoveritem.closest('tr');
                      var hp = row.querySelector(".claimHoverPopup");
                      if (hp) {
                          hp.style.display = "block";
                      } else {
                          console.error("Claim popup not found in the same row.");
                      }
                      }
      
                      function HidePopup(hoveritem) {
                      var row = hoveritem.closest('tr');
                      var hp = row.querySelector(".claimHoverPopup");
                      if (hp) {
                      hp.style.display = "none";
                      } else {
                      console.error("Claim popup not found in the same row.");
                      }
                      var action = <st:bind value="${it}" />;
                      }
      
                      function Display(hoveritem, error) {
                      var row = hoveritem.closest('tr');
                      var reasonText = row.querySelector('#errordesc');
                      var action = <st:bind value="${it}" />;
                      action.getReason(error, function(content) {
                      reasonText.textContent = content.responseObject();
                      });
                      }
                  </script>
      ----
      
      == Inline Event Handler
      Line: 40
      ----
      <a id="claim" href="#" onClick="ShowPopup(this); return false;">
      ----
      
      == Inline Event Handler
      Line: 54
      ----
      <a id="reassign" href="#" onClick="ShowPopup(this); return false;">
      ----
      
      == Inline Event Handler
      Line: 68
      ----
      <f:select onChange="Display(this, this.value);"/>
      ----
      
      == Inline Event Handler
      Line: 86
      ----
      <button type="button"  name="Cancel" formNoValidate="formNoValidate" class="jenkins-button jenkins-submit-button}" onClick="HidePopup(this);">
      ----
      

      Solutions

      https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
      https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

          [JENKINS-74109] [claim] Extract inline script block and event handlers in hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly

          Basil Crow created issue -
          Basil Crow made changes -
          Summary Original: [claim] Extract inline script blocks and lsevent handlers in hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly New: [claim] Extract inline script blocks and event handlers in hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly
          Basil Crow made changes -
          Assignee Original: Arnaud TAMAILLON [ greybird ]
          Basil Crow made changes -
          Description Original: h4. Problems

          {noformat}
          == Inline Script Block
          Line: 5
          ----
          <script type="text/javascript">
                          function ShowPopup(hoveritem) {
                          var row = hoveritem.closest('tr');
                          var hp = row.querySelector(".claimHoverPopup");
                          if (hp) {
                              hp.style.display = "block";
                          } else {
                              console.error("Claim popup not found in the same row.");
                          }
                          }

                          function HidePopup(hoveritem) {
                          var row = hoveritem.closest('tr');
                          var hp = row.querySelector(".claimHoverPopup");
                          if (hp) {
                          hp.style.display = "none";
                          } else {
                          console.error("Claim popup not found in the same row.");
                          }
                          var action = <st:bind value="${it}" />;
                          }

                          function Display(hoveritem, error) {
                          var row = hoveritem.closest('tr');
                          var reasonText = row.querySelector('#errordesc');
                          var action = <st:bind value="${it}" />;
                          action.getReason(error, function(content) {
                          reasonText.textContent = content.responseObject();
                          });
                          }
                      </script>
          ----

          == Inline Event Handler
          Line: 40
          ----
          <a id="claim" href="#" onClick="ShowPopup(this); return false;">
          ----

          == Inline Event Handler
          Line: 54
          ----
          <a id="reassign" href="#" onClick="ShowPopup(this); return false;">
          ----

          == Inline Event Handler
          Line: 68
          ----
          <f:select onChange="Display(this, this.value);"/>
          ----

          == Inline Event Handler
          Line: 86
          ----
          <button type="button" name="Cancel" formNoValidate="formNoValidate" class="jenkins-button jenkins-submit-button}" onClick="HidePopup(this);">
          ----

          == Inline Script Block
          Line: 5
          ----
          <script type="text/javascript">
                          function ShowPopup(hoveritem) {
                          var row = hoveritem.closest('tr');
                          var hp = row.querySelector(".claimHoverPopup");
                          if (hp) {
                              hp.style.display = "block";
                          } else {
                              console.error("Claim popup not found in the same row.");
                          }
                          }

                          function HidePopup(hoveritem) {
                          var row = hoveritem.closest('tr');
                          var hp = row.querySelector(".claimHoverPopup");
                          if (hp) {
                          hp.style.display = "none";
                          } else {
                          console.error("Claim popup not found in the same row.");
                          }
                          var action = <st:bind value="${it}" />;
                          }

                          function Display(hoveritem, error) {
                          var row = hoveritem.closest('tr');
                          var reasonText = row.querySelector('#errordesc');
                          var action = <st:bind value="${it}" />;
                          action.getReason(error, function(content) {
                          reasonText.textContent = content.responseObject();
                          });
                          }
                      </script>
          ----

          == Inline Event Handler
          Line: 40
          ----
          <a id="claim" href="#" onClick="ShowPopup(this); return false;">
          ----

          == Inline Event Handler
          Line: 54
          ----
          <a id="reassign" href="#" onClick="ShowPopup(this); return false;">
          ----

          == Inline Event Handler
          Line: 68
          ----
          <f:select onChange="Display(this, this.value);"/>
          ----

          == Inline Event Handler
          Line: 86
          ----
          <button type="button" name="Cancel" formNoValidate="formNoValidate" class="jenkins-button jenkins-submit-button}" onClick="HidePopup(this);">
          ----
          {noformat}

          h4. Solutions

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          New: h4. Problems

          {noformat}
          == Inline Script Block
          Line: 5
          ----
          <script type="text/javascript">
                          function ShowPopup(hoveritem) {
                          var row = hoveritem.closest('tr');
                          var hp = row.querySelector(".claimHoverPopup");
                          if (hp) {
                              hp.style.display = "block";
                          } else {
                              console.error("Claim popup not found in the same row.");
                          }
                          }

                          function HidePopup(hoveritem) {
                          var row = hoveritem.closest('tr');
                          var hp = row.querySelector(".claimHoverPopup");
                          if (hp) {
                          hp.style.display = "none";
                          } else {
                          console.error("Claim popup not found in the same row.");
                          }
                          var action = <st:bind value="${it}" />;
                          }

                          function Display(hoveritem, error) {
                          var row = hoveritem.closest('tr');
                          var reasonText = row.querySelector('#errordesc');
                          var action = <st:bind value="${it}" />;
                          action.getReason(error, function(content) {
                          reasonText.textContent = content.responseObject();
                          });
                          }
                      </script>
          ----

          == Inline Event Handler
          Line: 40
          ----
          <a id="claim" href="#" onClick="ShowPopup(this); return false;">
          ----

          == Inline Event Handler
          Line: 54
          ----
          <a id="reassign" href="#" onClick="ShowPopup(this); return false;">
          ----

          == Inline Event Handler
          Line: 68
          ----
          <f:select onChange="Display(this, this.value);"/>
          ----

          == Inline Event Handler
          Line: 86
          ----
          <button type="button" name="Cancel" formNoValidate="formNoValidate" class="jenkins-button jenkins-submit-button}" onClick="HidePopup(this);">
          ----
          {noformat}

          h4. Solutions

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          Summary Original: [claim] Extract inline script blocks and event handlers in hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly New: [claim] Extract inline script block and event handlers in hudson/plugins/claim/AbstractClaimBuildAction/tablerow.jelly
          Yaroslav Afenkin made changes -
          Assignee New: Yaroslav Afenkin [ yafenkin ]
          Yaroslav Afenkin made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Yaroslav Afenkin made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Yaroslav Afenkin made changes -
          Remote Link New: This issue links to "jenkinsci/claim-plugin/pull/335 (Web Link)" [ 30276 ]

          Basil Crow added a comment -

          Basil Crow added a comment - Fixed in jenkinsci/claim-plugin#335 . Released in tag/585.v619f52a_a_09dc .
          Basil Crow made changes -
          Released As New: 585.v619f52a_a_09dc
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Closed [ 6 ]

            yafenkin Yaroslav Afenkin
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: