• Type: Task
• Resolution: Unresolved
• Priority: Minor
• Component/s: ftppublisher-plugin
• Labels:

  • CSP

[JENKINS-74236] [ftppublisher] Extract inline event handler and migrate legacy checkUrl attribute in WEB-INF/classes/com/zanox/hudson/plugins/FTPPublisher/global.jelly

Basil Crow created issue - 2024-10-23 23:37

Basil Crow made changes - 2024-10-24 00:47

Assignee

Original: benjaminjaton [ benjaminjaton ]

Basil Crow made changes - 2024-10-24 15:03

Description	Original: h4. Problems {noformat} == Inline Event Handler Line: 30 ---- <input class="setting-input" name="ftp.password"                    type="password" value="${site.password}" onchange="Form.findMatchingInput(this,'ftp.username').onchange()"                     /> ---- == Legacy checkUrl Line: 26 ---- checkUrl="'${rootURL}/publisher/FTPPublisher/loginCheck?hostname='+escape(Form.findMatchingInput(this,'ftp.hostname').value)+'&amp;port='+escape(Form.findMatchingInput(this,'ftp.port').value)+'&amp;user='+escape(this.value)+'&amp;pass='+escape(Form.findMatchingInput(this,'ftp.password').value)+'&amp;ftpDir='+escape(Form.findMatchingInput(this,'ftp.ftpDir').value)" ---- == Inline Event Handler Line: 30 ---- <input class="setting-input" name="ftp.password"                    type="password" value="${site.password}" onchange="Form.findMatchingInput(this,'ftp.username').onchange()"                     /> ---- == Legacy checkUrl Line: 26 ---- checkUrl="'${rootURL}/publisher/FTPPublisher/loginCheck?hostname='+escape(Form.findMatchingInput(this,'ftp.hostname').value)+'&amp;port='+escape(Form.findMatchingInput(this,'ftp.port').value)+'&amp;user='+escape(this.value)+'&amp;pass='+escape(Form.findMatchingInput(this,'ftp.password').value)+'&amp;ftpDir='+escape(Form.findMatchingInput(this,'ftp.ftpDir').value)" ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers] [https://www.jenkins.io/doc/developer/security/csp/#legacy-javascript-checkurl-validation]	New: h4. Problems {noformat} == Legacy checkUrl Line: 26 ---- checkUrl="'${rootURL}/publisher/FTPPublisher/loginCheck?hostname='+escape(Form.findMatchingInput(this,'ftp.hostname').value)+'&amp;port='+escape(Form.findMatchingInput(this,'ftp.port').value)+'&amp;user='+escape(this.value)+'&amp;pass='+escape(Form.findMatchingInput(this,'ftp.password').value)+'&amp;ftpDir='+escape(Form.findMatchingInput(this,'ftp.ftpDir').value)" ---- == Inline Event Handler Line: 30 ---- <input class="setting-input" name="ftp.password"                    type="password" value="${site.password}" onchange="Form.findMatchingInput(this,'ftp.username').onchange()"                     /> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers] [https://www.jenkins.io/doc/developer/security/csp/#legacy-javascript-checkurl-validation]
Summary	Original: [ftppublisher] Extract inline event handlers and migrate legacy checkUrl attributes in WEB-INF/classes/com/zanox/hudson/plugins/FTPPublisher/global.jelly	New: [ftppublisher] Extract inline event handler and migrate legacy checkUrl attribute in WEB-INF/classes/com/zanox/hudson/plugins/FTPPublisher/global.jelly