Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74243

[jqs-monitoring] Extract inline script blocks and event handlers in org/jenkinsci/plugins/jqsmonitoring/jqscore/JQSMonitoring/config.jelly

      Problems

      == Inline Script Block
      Line: 150
      ----
      <script type="text/javascript"> function widthValue(newValue) {
      					document.getElementById("wrange").innerHTML=newValue; } 
      				</script>
      ----
      
      == Inline Script Block
      Line: 153
      ----
      <script type="text/javascript"> function heightValue(newValue) {
      					document.getElementById("hrange").innerHTML=newValue; } 
      				</script>
      ----
      
      == Inline Event Handler
      Line: 123
      ----
      <input
      								name="histwidth"
      								type="range"
      								min="25"
      								max="65"
      								value="${it.getLocalConfig().getHistogramWidth()}"
      								step="1"
      								onchange="widthValue(this.value)" />
      ----
      
      == Inline Event Handler
      Line: 138
      ----
      <input
      								name="histheight"
      								type="range"
      								min="250"
      								max="1200"
      								value="${it.getLocalConfig().getHistogramHeight()}"
      								step="10"
      								onchange="heightValue(this.value)" />
      ----
      

      Solutions

      https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
      https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

          [JENKINS-74243] [jqs-monitoring] Extract inline script blocks and event handlers in org/jenkinsci/plugins/jqsmonitoring/jqscore/JQSMonitoring/config.jelly

          Basil Crow created issue -
          Basil Crow made changes -
          Description Original: h4. Problems

          {noformat}
          == Inline Event Handler
          Line: 123
          ----
          <input
          name="histwidth"
          type="range"
          min="25"
          max="65"
          value="${it.getLocalConfig().getHistogramWidth()}"
          step="1"
          onchange="widthValue(this.value)" />
          ----

          == Inline Event Handler
          Line: 138
          ----
          <input
          name="histheight"
          type="range"
          min="250"
          max="1200"
          value="${it.getLocalConfig().getHistogramHeight()}"
          step="10"
          onchange="heightValue(this.value)" />
          ----

          == Inline Script Block
          Line: 150
          ----
          <script type="text/javascript"> function widthValue(newValue) {
          document.getElementById("wrange").innerHTML=newValue; }
          </script>
          ----

          == Inline Script Block
          Line: 153
          ----
          <script type="text/javascript"> function heightValue(newValue) {
          document.getElementById("hrange").innerHTML=newValue; }
          </script>
          ----

          == Inline Event Handler
          Line: 123
          ----
          <input
          name="histwidth"
          type="range"
          min="25"
          max="65"
          value="${it.getLocalConfig().getHistogramWidth()}"
          step="1"
          onchange="widthValue(this.value)" />
          ----

          == Inline Event Handler
          Line: 138
          ----
          <input
          name="histheight"
          type="range"
          min="250"
          max="1200"
          value="${it.getLocalConfig().getHistogramHeight()}"
          step="10"
          onchange="heightValue(this.value)" />
          ----

          == Inline Script Block
          Line: 150
          ----
          <script type="text/javascript"> function widthValue(newValue) {
          document.getElementById("wrange").innerHTML=newValue; }
          </script>
          ----

          == Inline Script Block
          Line: 153
          ----
          <script type="text/javascript"> function heightValue(newValue) {
          document.getElementById("hrange").innerHTML=newValue; }
          </script>
          ----
          {noformat}

          h4. Solutions

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          New: h4. Problems

          {noformat}
          == Inline Script Block
          Line: 150
          ----
          <script type="text/javascript"> function widthValue(newValue) {
          document.getElementById("wrange").innerHTML=newValue; }
          </script>
          ----

          == Inline Script Block
          Line: 153
          ----
          <script type="text/javascript"> function heightValue(newValue) {
          document.getElementById("hrange").innerHTML=newValue; }
          </script>
          ----

          == Inline Event Handler
          Line: 123
          ----
          <input
          name="histwidth"
          type="range"
          min="25"
          max="65"
          value="${it.getLocalConfig().getHistogramWidth()}"
          step="1"
          onchange="widthValue(this.value)" />
          ----

          == Inline Event Handler
          Line: 138
          ----
          <input
          name="histheight"
          type="range"
          min="250"
          max="1200"
          value="${it.getLocalConfig().getHistogramHeight()}"
          step="10"
          onchange="heightValue(this.value)" />
          ----
          {noformat}

          h4. Solutions

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]

            Unassigned Unassigned
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: