• Type: Task
• Resolution: Fixed
• Priority: Minor
• Component/s: custom-folder-icon-plugin
• Labels:

  • CSP

[JENKINS-74255] [custom-folder-icon] Extract inline script block and event handlers in jenkins/plugins/foldericon/CustomFolderIcon/config.jelly

Basil Crow created issue - 2024-10-23 23:39

Basil Crow made changes - 2024-10-24 00:48

Assignee

Original: Daniel Krämer [ strangelookingnerd ]

Basil Crow made changes - 2024-10-24 15:05

Description	Original: h4. Problems {noformat} == Inline Event Handler Line: 36 ---- <f:file id="custom-icon-upload" accept="image/*" onchange="setCustomIconFile(this.files[0])"                     clazz="custom-icon jenkins-file-upload" /> ---- == Inline Event Handler Line: 39 ---- <input type="button" value="${%Apply}"                    onclick="doUploadCustomIcon('${it.getUrl()}', '${%UploadSuccess}', '${%UploadFailed}')" /> ---- == Inline Event Handler Line: 47 ---- <img class="custom-icon-selection" src="${rootURL}/userContent/customFolderIcons/${icon}"                          onclick="setCustomIcon(this.src)" /> ---- == Inline Script Block Line: 57 ---- <script>         // init the preview         window.addEventListener("DOMContentLoaded", initCustomIcon());     </script> ---- == Inline Event Handler Line: 36 ---- <f:file id="custom-icon-upload" accept="image/*" onchange="setCustomIconFile(this.files[0])"                     clazz="custom-icon jenkins-file-upload" /> ---- == Inline Event Handler Line: 39 ---- <input type="button" value="${%Apply}"                    onclick="doUploadCustomIcon('${it.getUrl()}', '${%UploadSuccess}', '${%UploadFailed}')" /> ---- == Inline Event Handler Line: 47 ---- <img class="custom-icon-selection" src="${rootURL}/userContent/customFolderIcons/${icon}"                          onclick="setCustomIcon(this.src)" /> ---- == Inline Script Block Line: 57 ---- <script>         // init the preview         window.addEventListener("DOMContentLoaded", initCustomIcon());     </script> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]	New: h4. Problems {noformat} == Inline Script Block Line: 57 ---- <script>         // init the preview         window.addEventListener("DOMContentLoaded", initCustomIcon());     </script> ---- == Inline Event Handler Line: 36 ---- <f:file id="custom-icon-upload" accept="image/*" onchange="setCustomIconFile(this.files[0])"                     clazz="custom-icon jenkins-file-upload" /> ---- == Inline Event Handler Line: 39 ---- <input type="button" value="${%Apply}"                    onclick="doUploadCustomIcon('${it.getUrl()}', '${%UploadSuccess}', '${%UploadFailed}')" /> ---- == Inline Event Handler Line: 47 ---- <img class="custom-icon-selection" src="${rootURL}/userContent/customFolderIcons/${icon}"                          onclick="setCustomIcon(this.src)" /> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
Summary	Original: [custom-folder-icon] Extract inline script blocks and event handlers in jenkins/plugins/foldericon/CustomFolderIcon/config.jelly	New: [custom-folder-icon] Extract inline script block and event handlers in jenkins/plugins/foldericon/CustomFolderIcon/config.jelly

Daniel Krämer made changes - 2024-10-28 14:15

Assignee

New: Daniel Krämer [ strangelookingnerd ]

Daniel Krämer made changes - 2024-10-28 14:17

Released As		New: 2.15
Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Resolved [ 5 ]

Basil Crow made changes - 2024-10-28 21:05

Status

Original: Resolved [ 5 ]

New: Closed [ 6 ]