• Type: Task
• Resolution: Unresolved
• Priority: Minor
• Component/s: exclusion-plugin
• Labels:

  • CSP

[JENKINS-74278] [Exclusion] Extract inline script block and event handler in org/jvnet/hudson/plugins/exclusion/AdministrationPanel/index.jelly

Basil Crow created issue - 2024-10-23 23:41

Basil Crow made changes - 2024-10-24 15:07

Description	Original: h4. Problems {noformat} == Inline Event Handler Line: 60 ---- <a title="Force to release resource" href="#"                                onclick="releaseExclusionResource(this); return false;"                                data-runid="${resource.runId}"                                data-resourceid="${resource.resourceId}"> ---- == Inline Script Block Line: 30 ---- <script>                 function releaseExclusionResource(e)                 {                 var form = document.freeResource;                     // Jenkins tests use HtmlUnit which does not support dataset                     //form.resourceId.value = e.dataset.resourceid;                     //form.runId.value = e.dataset.runid;                     form.resourceId.value = e.getAttribute('data-resourceid');                     form.runId.value = e.getAttribute('data-runid');                 form.submit();                 }             </script> ---- == Inline Event Handler Line: 60 ---- <a title="Force to release resource" href="#"                                onclick="releaseExclusionResource(this); return false;"                                data-runid="${resource.runId}"                                data-resourceid="${resource.resourceId}"> ---- == Inline Script Block Line: 30 ---- <script>                 function releaseExclusionResource(e)                 {                 var form = document.freeResource;                     // Jenkins tests use HtmlUnit which does not support dataset                     //form.resourceId.value = e.dataset.resourceid;                     //form.runId.value = e.dataset.runid;                     form.resourceId.value = e.getAttribute('data-resourceid');                     form.runId.value = e.getAttribute('data-runid');                 form.submit();                 }             </script> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]	New: h4. Problems {noformat} == Inline Script Block Line: 30 ---- <script>                 function releaseExclusionResource(e)                 {                 var form = document.freeResource;                     // Jenkins tests use HtmlUnit which does not support dataset                     //form.resourceId.value = e.dataset.resourceid;                     //form.runId.value = e.dataset.runid;                     form.resourceId.value = e.getAttribute('data-resourceid');                     form.runId.value = e.getAttribute('data-runid');                 form.submit();                 }             </script> ---- == Inline Event Handler Line: 60 ---- <a title="Force to release resource" href="#"                                onclick="releaseExclusionResource(this); return false;"                                data-runid="${resource.runId}"                                data-resourceid="${resource.resourceId}"> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
Summary	Original: [Exclusion] Extract inline script blocks and event handlers in org/jvnet/hudson/plugins/exclusion/AdministrationPanel/index.jelly	New: [Exclusion] Extract inline script block and event handler in org/jvnet/hudson/plugins/exclusion/AdministrationPanel/index.jelly