Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74285

[klocwork] Extract inline event handlers in com/klocwork/kwjenkinsplugin/reporting/KlocworkResultsAction/issue.jelly

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • klocwork-plugin

      Note

      While testing this plugin, evaluate whether the third-party libraries in src/main/webapp are compatible with CSP in restrictive mode. The plugin may need to be upgraded from jQuery 1.x to 3.x to fully function in CSP restrictive mode.

      Problems

      == Inline Event Handler
      Line: 6
      ----
      <a class="issue-file block link-style-none collapsible ${initialCollapse}"
                     onclick="Klocwork.toggle(this, 'issueDetails${groupCount}')">
      ----
      
      == Inline Event Handler
      Line: 44
      ----
      <a id="${idPrefix}issueLinkElement${issueId}"
                                         class="link-style-none ${traceClass} block collapsed"
                                         onclick="Klocwork.toggle(this, 'fullIssueDetails${issueId}')">
      ----
      
      == Inline Event Handler
      Line: 56
      ----
      <button id="showIssueCitation${issueId}" class="button-edit button-blank" onclick="event.stopPropagation();Klocwork.showAuthenticationOrCitation(${issueId})">
      ----
      
      == Inline Event Handler
      Line: 84
      ----
      <button class="issue-cite-save-control" id="issueCiteSave${issueId}" onclick="Klocwork.saveCitation(${issueId})">
      ----
      
      == Inline Event Handler
      Line: 85
      ----
      <button class="issue-cite-save-control" id="issueCiteCancel${issueId}" onclick="Klocwork.cancelCitation(${issueId})">
      ----
      

      Solution

      https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

          [JENKINS-74285] [klocwork] Extract inline event handlers in com/klocwork/kwjenkinsplugin/reporting/KlocworkResultsAction/issue.jelly

          Basil Crow created issue -
          Basil Crow made changes -
          Assignee Original: Jacob Lärfors [ jlarfors ]
          Basil Crow made changes -
          Description Original: h4. Problems

          {noformat}
          == Inline Event Handler
          Line: 6
          ----
          <a class="issue-file block link-style-none collapsible ${initialCollapse}"
                         onclick="Klocwork.toggle(this, 'issueDetails${groupCount}')">
          ----

          == Inline Event Handler
          Line: 44
          ----
          <a id="${idPrefix}issueLinkElement${issueId}"
                                             class="link-style-none ${traceClass} block collapsed"
                                             onclick="Klocwork.toggle(this, 'fullIssueDetails${issueId}')">
          ----

          == Inline Event Handler
          Line: 56
          ----
          <button id="showIssueCitation${issueId}" class="button-edit button-blank" onclick="event.stopPropagation();Klocwork.showAuthenticationOrCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 84
          ----
          <button class="issue-cite-save-control" id="issueCiteSave${issueId}" onclick="Klocwork.saveCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 85
          ----
          <button class="issue-cite-save-control" id="issueCiteCancel${issueId}" onclick="Klocwork.cancelCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 6
          ----
          <a class="issue-file block link-style-none collapsible ${initialCollapse}"
                         onclick="Klocwork.toggle(this, 'issueDetails${groupCount}')">
          ----

          == Inline Event Handler
          Line: 44
          ----
          <a id="${idPrefix}issueLinkElement${issueId}"
                                             class="link-style-none ${traceClass} block collapsed"
                                             onclick="Klocwork.toggle(this, 'fullIssueDetails${issueId}')">
          ----

          == Inline Event Handler
          Line: 56
          ----
          <button id="showIssueCitation${issueId}" class="button-edit button-blank" onclick="event.stopPropagation();Klocwork.showAuthenticationOrCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 84
          ----
          <button class="issue-cite-save-control" id="issueCiteSave${issueId}" onclick="Klocwork.saveCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 85
          ----
          <button class="issue-cite-save-control" id="issueCiteCancel${issueId}" onclick="Klocwork.cancelCitation(${issueId})">
          ----
          {noformat}

          h4. Solution

          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          New: h4. Problems

          {noformat}
          == Inline Event Handler
          Line: 6
          ----
          <a class="issue-file block link-style-none collapsible ${initialCollapse}"
                         onclick="Klocwork.toggle(this, 'issueDetails${groupCount}')">
          ----

          == Inline Event Handler
          Line: 44
          ----
          <a id="${idPrefix}issueLinkElement${issueId}"
                                             class="link-style-none ${traceClass} block collapsed"
                                             onclick="Klocwork.toggle(this, 'fullIssueDetails${issueId}')">
          ----

          == Inline Event Handler
          Line: 56
          ----
          <button id="showIssueCitation${issueId}" class="button-edit button-blank" onclick="event.stopPropagation();Klocwork.showAuthenticationOrCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 84
          ----
          <button class="issue-cite-save-control" id="issueCiteSave${issueId}" onclick="Klocwork.saveCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 85
          ----
          <button class="issue-cite-save-control" id="issueCiteCancel${issueId}" onclick="Klocwork.cancelCitation(${issueId})">
          ----
          {noformat}

          h4. Solution

          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          Basil Crow made changes -
          Description Original: h4. Problems

          {noformat}
          == Inline Event Handler
          Line: 6
          ----
          <a class="issue-file block link-style-none collapsible ${initialCollapse}"
                         onclick="Klocwork.toggle(this, 'issueDetails${groupCount}')">
          ----

          == Inline Event Handler
          Line: 44
          ----
          <a id="${idPrefix}issueLinkElement${issueId}"
                                             class="link-style-none ${traceClass} block collapsed"
                                             onclick="Klocwork.toggle(this, 'fullIssueDetails${issueId}')">
          ----

          == Inline Event Handler
          Line: 56
          ----
          <button id="showIssueCitation${issueId}" class="button-edit button-blank" onclick="event.stopPropagation();Klocwork.showAuthenticationOrCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 84
          ----
          <button class="issue-cite-save-control" id="issueCiteSave${issueId}" onclick="Klocwork.saveCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 85
          ----
          <button class="issue-cite-save-control" id="issueCiteCancel${issueId}" onclick="Klocwork.cancelCitation(${issueId})">
          ----
          {noformat}

          h4. Solution

          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          New: h1. Note

          *While testing this plugin, evaluate whether the third-party libraries in {{src/main/webapp}} are compatible with CSP in restrictive mode. The plugin may need to be upgraded from jQuery 1.x to 3.x to fully function in CSP restrictive mode.*

          h4. Problems

          {noformat}
          == Inline Event Handler
          Line: 6
          ----
          <a class="issue-file block link-style-none collapsible ${initialCollapse}"
                         onclick="Klocwork.toggle(this, 'issueDetails${groupCount}')">
          ----

          == Inline Event Handler
          Line: 44
          ----
          <a id="${idPrefix}issueLinkElement${issueId}"
                                             class="link-style-none ${traceClass} block collapsed"
                                             onclick="Klocwork.toggle(this, 'fullIssueDetails${issueId}')">
          ----

          == Inline Event Handler
          Line: 56
          ----
          <button id="showIssueCitation${issueId}" class="button-edit button-blank" onclick="event.stopPropagation();Klocwork.showAuthenticationOrCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 84
          ----
          <button class="issue-cite-save-control" id="issueCiteSave${issueId}" onclick="Klocwork.saveCitation(${issueId})">
          ----

          == Inline Event Handler
          Line: 85
          ----
          <button class="issue-cite-save-control" id="issueCiteCancel${issueId}" onclick="Klocwork.cancelCitation(${issueId})">
          ----
          {noformat}

          h4. Solution

          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]

            Unassigned Unassigned
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: