-
Task
-
Resolution: Unresolved
-
Minor
Note
While testing this plugin, evaluate whether the third-party libraries in src/main/webapp are compatible with CSP in restrictive mode. The plugin may need to be upgraded from jQuery 1.x to 3.x to fully function in CSP restrictive mode.
Problem
== Inline Script Block
Line: 6
----
<script type="text/javascript">
jQuery.noConflict();
jQuery(document).ready(function(){
jQuery("a.leaf").each(function(idx, el) {
var html = jQuery(el).clone().find('img').attr("width", ${from.imageInnerWidthText}).end().html();
jQuery(el).colorbox({
inline: false,
photo: true,
close: '${%Close}',
innerWidth: Math.min((2 * ${from.imageInnerWidthText}) + 25, jQuery(window).width() - 50),
height: '100%',
html: '<div style="overflow: auto; float: left;">' + html + "</div>"
});
});
var tree = jQuery(".comparative-gallery-tree").jstree({
"plugins" : [ "themes", "html_data" ] ,
core : {
"animation" : 0
}
});
tree.find('.leaf').css('height', ${from.imageWidthText} + 10);
});
</script>
----
Solution
https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
[JENKINS-74300] [image-gallery] Extract inline script block in org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction/summary.jelly
Basil Crow
created issue -
Basil Crow
made changes -
| Assignee | Original: Bruno P. Kinoshita [ kinow ] |
Basil Crow
made changes -
| Description |
Original:
h4. Problems {noformat} == Inline Script Block Line: 6 ---- <script type="text/javascript"> jQuery.noConflict(); jQuery(document).ready(function(){ jQuery("a.leaf").each(function(idx, el) { var html = jQuery(el).clone().find('img').attr("width", ${from.imageInnerWidthText}).end().html(); jQuery(el).colorbox({ inline: false, photo: true, close: '${%Close}', innerWidth: Math.min((2 * ${from.imageInnerWidthText}) + 25, jQuery(window).width() - 50), height: '100%', html: '<div style="overflow: auto; float: left;">' + html + "</div>" }); }); var tree = jQuery(".comparative-gallery-tree").jstree({ "plugins" : [ "themes", "html_data" ] , core : { "animation" : 0 } }); tree.find('.leaf').css('height', ${from.imageWidthText} + 10); }); </script> ---- == Inline Script Block Line: 6 ---- <script type="text/javascript"> jQuery.noConflict(); jQuery(document).ready(function(){ jQuery("a.leaf").each(function(idx, el) { var html = jQuery(el).clone().find('img').attr("width", ${from.imageInnerWidthText}).end().html(); jQuery(el).colorbox({ inline: false, photo: true, close: '${%Close}', innerWidth: Math.min((2 * ${from.imageInnerWidthText}) + 25, jQuery(window).width() - 50), height: '100%', html: '<div style="overflow: auto; float: left;">' + html + "</div>" }); }); var tree = jQuery(".comparative-gallery-tree").jstree({ "plugins" : [ "themes", "html_data" ] , core : { "animation" : 0 } }); tree.find('.leaf').css('height', ${from.imageWidthText} + 10); }); </script> ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] |
New:
h4. Problem {noformat} == Inline Script Block Line: 6 ---- <script type="text/javascript"> jQuery.noConflict(); jQuery(document).ready(function(){ jQuery("a.leaf").each(function(idx, el) { var html = jQuery(el).clone().find('img').attr("width", ${from.imageInnerWidthText}).end().html(); jQuery(el).colorbox({ inline: false, photo: true, close: '${%Close}', innerWidth: Math.min((2 * ${from.imageInnerWidthText}) + 25, jQuery(window).width() - 50), height: '100%', html: '<div style="overflow: auto; float: left;">' + html + "</div>" }); }); var tree = jQuery(".comparative-gallery-tree").jstree({ "plugins" : [ "themes", "html_data" ] , core : { "animation" : 0 } }); tree.find('.leaf').css('height', ${from.imageWidthText} + 10); }); </script> ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] |
| Summary | Original: [image-gallery] Extract inline script blocks in org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction/summary.jelly | New: [image-gallery] Extract inline script block in org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction/summary.jelly |
Basil Crow
made changes -
| Description |
Original:
h4. Problem {noformat} == Inline Script Block Line: 6 ---- <script type="text/javascript"> jQuery.noConflict(); jQuery(document).ready(function(){ jQuery("a.leaf").each(function(idx, el) { var html = jQuery(el).clone().find('img').attr("width", ${from.imageInnerWidthText}).end().html(); jQuery(el).colorbox({ inline: false, photo: true, close: '${%Close}', innerWidth: Math.min((2 * ${from.imageInnerWidthText}) + 25, jQuery(window).width() - 50), height: '100%', html: '<div style="overflow: auto; float: left;">' + html + "</div>" }); }); var tree = jQuery(".comparative-gallery-tree").jstree({ "plugins" : [ "themes", "html_data" ] , core : { "animation" : 0 } }); tree.find('.leaf').css('height', ${from.imageWidthText} + 10); }); </script> ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] |
New:
h1. Note
*While testing this plugin, evaluate whether the third-party libraries in {{src/main/webapp}} are compatible with CSP in restrictive mode. The plugin may need to be upgraded from jQuery 1.x to 3.x to fully function in CSP restrictive mode.* h4. Problem {noformat} == Inline Script Block Line: 6 ---- <script type="text/javascript"> jQuery.noConflict(); jQuery(document).ready(function(){ jQuery("a.leaf").each(function(idx, el) { var html = jQuery(el).clone().find('img').attr("width", ${from.imageInnerWidthText}).end().html(); jQuery(el).colorbox({ inline: false, photo: true, close: '${%Close}', innerWidth: Math.min((2 * ${from.imageInnerWidthText}) + 25, jQuery(window).width() - 50), height: '100%', html: '<div style="overflow: auto; float: left;">' + html + "</div>" }); }); var tree = jQuery(".comparative-gallery-tree").jstree({ "plugins" : [ "themes", "html_data" ] , core : { "animation" : 0 } }); tree.find('.leaf').css('height', ${from.imageWidthText} + 10); }); </script> ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] |