-
Task
-
Resolution: Unresolved
-
Minor
Note
While testing this plugin, evaluate whether the third-party libraries in src/main/webapp are compatible with CSP in restrictive mode. The plugin may need to be upgraded from jQuery 1.x to 3.x to fully function in CSP restrictive mode.
Problems
== Legacy checkUrl
Line: 21
----
checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseHost?value='+toValue(this)"
----
== Legacy checkUrl
Line: 28
----
checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)"
----
== Legacy checkUrl
Line: 61
----
checkUrl="'${rootURL}/defaultJDKCheck?value='+this.value"
----
== Legacy checkUrl
Line: 72
----
checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaOpts?value='+toValue(this)"
----
== Legacy checkUrl
Line: 79
----
checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaWorkingDirectory?value='+toValue(this)"
----
== Legacy checkUrl
Line: 86
----
checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToJar?value='+toValue(this)"
----
== Legacy checkUrl
Line: 93
----
checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToRoot?value='+toValue(this)"
----
== Legacy checkUrl
Line: 100
----
checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)"
----
== Legacy checkUrl
Line: 107
----
checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkAdditionalFitnesseOptions?value='+toValue(this)"
----
Solution
https://www.jenkins.io/doc/developer/security/csp/#legacy-javascript-checkurl-validation
[JENKINS-74329] [fitnesse] Migrate legacy checkUrl attributes in hudson/plugins/fitnesse/FitnesseBuilder/config.jelly
Basil Crow
created issue -
Basil Crow
made changes -
| Description |
Original:
h4. Problems {noformat} == Legacy checkUrl Line: 21 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseHost?value='+toValue(this)" ---- == Legacy checkUrl Line: 28 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 61 ---- checkUrl="'${rootURL}/defaultJDKCheck?value='+this.value" ---- == Legacy checkUrl Line: 72 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaOpts?value='+toValue(this)" ---- == Legacy checkUrl Line: 79 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaWorkingDirectory?value='+toValue(this)" ---- == Legacy checkUrl Line: 86 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToJar?value='+toValue(this)" ---- == Legacy checkUrl Line: 93 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToRoot?value='+toValue(this)" ---- == Legacy checkUrl Line: 100 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 107 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkAdditionalFitnesseOptions?value='+toValue(this)" ---- == Legacy checkUrl Line: 21 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseHost?value='+toValue(this)" ---- == Legacy checkUrl Line: 28 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 61 ---- checkUrl="'${rootURL}/defaultJDKCheck?value='+this.value" ---- == Legacy checkUrl Line: 72 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaOpts?value='+toValue(this)" ---- == Legacy checkUrl Line: 79 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaWorkingDirectory?value='+toValue(this)" ---- == Legacy checkUrl Line: 86 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToJar?value='+toValue(this)" ---- == Legacy checkUrl Line: 93 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToRoot?value='+toValue(this)" ---- == Legacy checkUrl Line: 100 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 107 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkAdditionalFitnesseOptions?value='+toValue(this)" ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#legacy-javascript-checkurl-validation] |
New:
h4. Problems {noformat} == Legacy checkUrl Line: 21 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseHost?value='+toValue(this)" ---- == Legacy checkUrl Line: 28 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 61 ---- checkUrl="'${rootURL}/defaultJDKCheck?value='+this.value" ---- == Legacy checkUrl Line: 72 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaOpts?value='+toValue(this)" ---- == Legacy checkUrl Line: 79 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaWorkingDirectory?value='+toValue(this)" ---- == Legacy checkUrl Line: 86 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToJar?value='+toValue(this)" ---- == Legacy checkUrl Line: 93 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToRoot?value='+toValue(this)" ---- == Legacy checkUrl Line: 100 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 107 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkAdditionalFitnesseOptions?value='+toValue(this)" ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#legacy-javascript-checkurl-validation] |
Basil Crow
made changes -
| Description |
Original:
h4. Problems {noformat} == Legacy checkUrl Line: 21 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseHost?value='+toValue(this)" ---- == Legacy checkUrl Line: 28 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 61 ---- checkUrl="'${rootURL}/defaultJDKCheck?value='+this.value" ---- == Legacy checkUrl Line: 72 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaOpts?value='+toValue(this)" ---- == Legacy checkUrl Line: 79 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaWorkingDirectory?value='+toValue(this)" ---- == Legacy checkUrl Line: 86 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToJar?value='+toValue(this)" ---- == Legacy checkUrl Line: 93 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToRoot?value='+toValue(this)" ---- == Legacy checkUrl Line: 100 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 107 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkAdditionalFitnesseOptions?value='+toValue(this)" ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#legacy-javascript-checkurl-validation] |
New:
h1. Note
*While testing this plugin, evaluate whether the third-party libraries in {{src/main/webapp}} are compatible with CSP in restrictive mode. The plugin may need to be upgraded from jQuery 1.x to 3.x to fully function in CSP restrictive mode.* h4. Problems {noformat} == Legacy checkUrl Line: 21 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseHost?value='+toValue(this)" ---- == Legacy checkUrl Line: 28 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 61 ---- checkUrl="'${rootURL}/defaultJDKCheck?value='+this.value" ---- == Legacy checkUrl Line: 72 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaOpts?value='+toValue(this)" ---- == Legacy checkUrl Line: 79 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnesseJavaWorkingDirectory?value='+toValue(this)" ---- == Legacy checkUrl Line: 86 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToJar?value='+toValue(this)" ---- == Legacy checkUrl Line: 93 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePathToRoot?value='+toValue(this)" ---- == Legacy checkUrl Line: 100 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkFitnessePort?value='+toValue(this)" ---- == Legacy checkUrl Line: 107 ---- checkUrl="'descriptorByName/hudson.plugins.fitnesse.FitnesseBuilder/checkAdditionalFitnesseOptions?value='+toValue(this)" ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#legacy-javascript-checkurl-validation] |