Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74361

[selected-tests-executor] Extract inline script block and event handlers in WEB-INF/classes/il/ac/technion/jenkins/plugins/TestExecuter/config.jelly

      Problems

      == Inline Script Block
      Line: 4
      ----
      <script type="text/javascript">
      		var TestExecuterRPC = <st:bind value="${descriptor}" />;
      	</script>
      ----
      
      == Inline Event Handler
      Line: 27
      ----
      <input type="button" value="Fetch Properties From File"
      			onclick="loadSettingsFromPropertiesFile('propertiesFilePath_${instance.uuid}', 'enableField_${instance.uuid}', 'groupBy_${instance.uuid}', 'showFields_${instance.uuid}', 'multiplicityField_${instance.uuid}', 'fieldSeparator_${instance.uuid}')" />
      ----
      
      == Inline Event Handler
      Line: 30
      ----
      <input type="button" value="Show Available Fields"
      			onclick="showHideAvailableFields(this, '${instance.uuid}')"/>
      ----
      
      == Inline Event Handler
      Line: 40
      ----
      <f:textbox id="enableField_${instance.uuid}"
      							onkeyup="onPropertyChange('enableFieldSelect_${instance.uuid}')"
      							value='${instance.enableField != null ? instance.enableField.text : ""}'
      							placeholder="Field name of the field suggesting if the test is enabled or not" />
      ----
      
      == Inline Event Handler
      Line: 46
      ----
      <select id="enableFieldSelect_${instance.uuid}" style="display:none"
      							onchange="document.getElementById('enableField_${instance.uuid}').value = this.options[this.selectedIndex].value">
      ----
      
      == Inline Event Handler
      Line: 60
      ----
      <f:textbox id="groupBy_${instance.uuid}"
      							onkeyup="onPropertyChange('groupBySelect_${instance.uuid}')"
      							value='${instance.groupBy != null ? instance.groupBy.text : ""}'
      							placeholder="The field(s) that the tests will be grouped by"/>
      ----
      
      == Inline Event Handler
      Line: 66
      ----
      <select id="groupBySelect_${instance.uuid}" style="display:none"
      							onchange="document.getElementById('groupBy_${instance.uuid}').value = this.options[this.selectedIndex].value">
      ----
      
      == Inline Event Handler
      Line: 98
      ----
      <f:textbox id="multiplicityField_${instance.uuid}"
      							onkeyup="onPropertyChange('multiplicityFieldSelect_${instance.uuid}')"
      							value='${instance.multiplicityField != null ? instance.multiplicityField.text : ""}'
      							placeholder="The field that will be set to the amount of time the test should run" />
      ----
      
      == Inline Event Handler
      Line: 104
      ----
      <select id="multiplicityFieldSelect_${instance.uuid}"
      							style="display:none"
      							onchange="document.getElementById('multiplicityField_${instance.uuid}').value = this.options[this.selectedIndex].value">
      ----
      

      Solutions

      https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
      https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

          [JENKINS-74361] [selected-tests-executor] Extract inline script block and event handlers in WEB-INF/classes/il/ac/technion/jenkins/plugins/TestExecuter/config.jelly

          Basil Crow created issue -
          Basil Crow made changes -
          Description Original: h4. Problems

          {noformat}
          == Inline Event Handler
          Line: 27
          ----
          <input type="button" value="Fetch Properties From File"
          onclick="loadSettingsFromPropertiesFile('propertiesFilePath_${instance.uuid}', 'enableField_${instance.uuid}', 'groupBy_${instance.uuid}', 'showFields_${instance.uuid}', 'multiplicityField_${instance.uuid}', 'fieldSeparator_${instance.uuid}')" />
          ----

          == Inline Event Handler
          Line: 30
          ----
          <input type="button" value="Show Available Fields"
          onclick="showHideAvailableFields(this, '${instance.uuid}')"/>
          ----

          == Inline Event Handler
          Line: 40
          ----
          <f:textbox id="enableField_${instance.uuid}"
          onkeyup="onPropertyChange('enableFieldSelect_${instance.uuid}')"
          value='${instance.enableField != null ? instance.enableField.text : ""}'
          placeholder="Field name of the field suggesting if the test is enabled or not" />
          ----

          == Inline Event Handler
          Line: 46
          ----
          <select id="enableFieldSelect_${instance.uuid}" style="display:none"
          onchange="document.getElementById('enableField_${instance.uuid}').value = this.options[this.selectedIndex].value">
          ----

          == Inline Event Handler
          Line: 60
          ----
          <f:textbox id="groupBy_${instance.uuid}"
          onkeyup="onPropertyChange('groupBySelect_${instance.uuid}')"
          value='${instance.groupBy != null ? instance.groupBy.text : ""}'
          placeholder="The field(s) that the tests will be grouped by"/>
          ----

          == Inline Event Handler
          Line: 66
          ----
          <select id="groupBySelect_${instance.uuid}" style="display:none"
          onchange="document.getElementById('groupBy_${instance.uuid}').value = this.options[this.selectedIndex].value">
          ----

          == Inline Event Handler
          Line: 98
          ----
          <f:textbox id="multiplicityField_${instance.uuid}"
          onkeyup="onPropertyChange('multiplicityFieldSelect_${instance.uuid}')"
          value='${instance.multiplicityField != null ? instance.multiplicityField.text : ""}'
          placeholder="The field that will be set to the amount of time the test should run" />
          ----

          == Inline Event Handler
          Line: 104
          ----
          <select id="multiplicityFieldSelect_${instance.uuid}"
          style="display:none"
          onchange="document.getElementById('multiplicityField_${instance.uuid}').value = this.options[this.selectedIndex].value">
          ----

          == Inline Script Block
          Line: 4
          ----
          <script type="text/javascript">
          var TestExecuterRPC = <st:bind value="${descriptor}" />;
          </script>
          ----

          == Inline Event Handler
          Line: 27
          ----
          <input type="button" value="Fetch Properties From File"
          onclick="loadSettingsFromPropertiesFile('propertiesFilePath_${instance.uuid}', 'enableField_${instance.uuid}', 'groupBy_${instance.uuid}', 'showFields_${instance.uuid}', 'multiplicityField_${instance.uuid}', 'fieldSeparator_${instance.uuid}')" />
          ----

          == Inline Event Handler
          Line: 30
          ----
          <input type="button" value="Show Available Fields"
          onclick="showHideAvailableFields(this, '${instance.uuid}')"/>
          ----

          == Inline Event Handler
          Line: 40
          ----
          <f:textbox id="enableField_${instance.uuid}"
          onkeyup="onPropertyChange('enableFieldSelect_${instance.uuid}')"
          value='${instance.enableField != null ? instance.enableField.text : ""}'
          placeholder="Field name of the field suggesting if the test is enabled or not" />
          ----

          == Inline Event Handler
          Line: 46
          ----
          <select id="enableFieldSelect_${instance.uuid}" style="display:none"
          onchange="document.getElementById('enableField_${instance.uuid}').value = this.options[this.selectedIndex].value">
          ----

          == Inline Event Handler
          Line: 60
          ----
          <f:textbox id="groupBy_${instance.uuid}"
          onkeyup="onPropertyChange('groupBySelect_${instance.uuid}')"
          value='${instance.groupBy != null ? instance.groupBy.text : ""}'
          placeholder="The field(s) that the tests will be grouped by"/>
          ----

          == Inline Event Handler
          Line: 66
          ----
          <select id="groupBySelect_${instance.uuid}" style="display:none"
          onchange="document.getElementById('groupBy_${instance.uuid}').value = this.options[this.selectedIndex].value">
          ----

          == Inline Event Handler
          Line: 98
          ----
          <f:textbox id="multiplicityField_${instance.uuid}"
          onkeyup="onPropertyChange('multiplicityFieldSelect_${instance.uuid}')"
          value='${instance.multiplicityField != null ? instance.multiplicityField.text : ""}'
          placeholder="The field that will be set to the amount of time the test should run" />
          ----

          == Inline Event Handler
          Line: 104
          ----
          <select id="multiplicityFieldSelect_${instance.uuid}"
          style="display:none"
          onchange="document.getElementById('multiplicityField_${instance.uuid}').value = this.options[this.selectedIndex].value">
          ----

          == Inline Script Block
          Line: 4
          ----
          <script type="text/javascript">
          var TestExecuterRPC = <st:bind value="${descriptor}" />;
          </script>
          ----
          {noformat}

          h4. Solutions

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          New: h4. Problems

          {noformat}
          == Inline Script Block
          Line: 4
          ----
          <script type="text/javascript">
          var TestExecuterRPC = <st:bind value="${descriptor}" />;
          </script>
          ----

          == Inline Event Handler
          Line: 27
          ----
          <input type="button" value="Fetch Properties From File"
          onclick="loadSettingsFromPropertiesFile('propertiesFilePath_${instance.uuid}', 'enableField_${instance.uuid}', 'groupBy_${instance.uuid}', 'showFields_${instance.uuid}', 'multiplicityField_${instance.uuid}', 'fieldSeparator_${instance.uuid}')" />
          ----

          == Inline Event Handler
          Line: 30
          ----
          <input type="button" value="Show Available Fields"
          onclick="showHideAvailableFields(this, '${instance.uuid}')"/>
          ----

          == Inline Event Handler
          Line: 40
          ----
          <f:textbox id="enableField_${instance.uuid}"
          onkeyup="onPropertyChange('enableFieldSelect_${instance.uuid}')"
          value='${instance.enableField != null ? instance.enableField.text : ""}'
          placeholder="Field name of the field suggesting if the test is enabled or not" />
          ----

          == Inline Event Handler
          Line: 46
          ----
          <select id="enableFieldSelect_${instance.uuid}" style="display:none"
          onchange="document.getElementById('enableField_${instance.uuid}').value = this.options[this.selectedIndex].value">
          ----

          == Inline Event Handler
          Line: 60
          ----
          <f:textbox id="groupBy_${instance.uuid}"
          onkeyup="onPropertyChange('groupBySelect_${instance.uuid}')"
          value='${instance.groupBy != null ? instance.groupBy.text : ""}'
          placeholder="The field(s) that the tests will be grouped by"/>
          ----

          == Inline Event Handler
          Line: 66
          ----
          <select id="groupBySelect_${instance.uuid}" style="display:none"
          onchange="document.getElementById('groupBy_${instance.uuid}').value = this.options[this.selectedIndex].value">
          ----

          == Inline Event Handler
          Line: 98
          ----
          <f:textbox id="multiplicityField_${instance.uuid}"
          onkeyup="onPropertyChange('multiplicityFieldSelect_${instance.uuid}')"
          value='${instance.multiplicityField != null ? instance.multiplicityField.text : ""}'
          placeholder="The field that will be set to the amount of time the test should run" />
          ----

          == Inline Event Handler
          Line: 104
          ----
          <select id="multiplicityFieldSelect_${instance.uuid}"
          style="display:none"
          onchange="document.getElementById('multiplicityField_${instance.uuid}').value = this.options[this.selectedIndex].value">
          ----
          {noformat}

          h4. Solutions

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
          Summary Original: [selected-tests-executor] Extract inline script blocks and event handlers in WEB-INF/classes/il/ac/technion/jenkins/plugins/TestExecuter/config.jelly New: [selected-tests-executor] Extract inline script block and event handlers in WEB-INF/classes/il/ac/technion/jenkins/plugins/TestExecuter/config.jelly

            Unassigned Unassigned
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: