• Type: Task
• Resolution: Unresolved
• Priority: Minor
• Component/s: selected-tests-executor-plugin
• Labels:

  • CSP

[JENKINS-74362] [selected-tests-executor] Extract inline script block and event handlers in WEB-INF/classes/il/ac/technion/jenkins/plugins/TestExecuter/index.jelly

Basil Crow created issue - 2024-10-23 23:50

Basil Crow made changes - 2024-10-24 15:15

Description	Original: h4. Problems {noformat} == Inline Event Handler Line: 65 ---- <input type="button" value="Select All" onclick="selectGroupInDiv('testsTreeContainer_${it.uuid}', true);"/> ---- == Inline Event Handler Line: 66 ---- <input type="button" value="Unselect All" onclick="selectGroupInDiv('testsTreeContainer_${it.uuid}', false);"/> ---- == Inline Script Block Line: 77 ---- <script type="text/javascript"> var TestExecuterRPC = <st:bind value="${it}"/>; loadTreeFromFile("${it.propertiesFilePath}", "selectedTests_${it.uuid}", "testsTreeContainer_${it.uuid}", ${it.getAsJson()}); </script> ---- == Inline Event Handler Line: 65 ---- <input type="button" value="Select All" onclick="selectGroupInDiv('testsTreeContainer_${it.uuid}', true);"/> ---- == Inline Event Handler Line: 66 ---- <input type="button" value="Unselect All" onclick="selectGroupInDiv('testsTreeContainer_${it.uuid}', false);"/> ---- == Inline Script Block Line: 77 ---- <script type="text/javascript"> var TestExecuterRPC = <st:bind value="${it}"/>; loadTreeFromFile("${it.propertiesFilePath}", "selectedTests_${it.uuid}", "testsTreeContainer_${it.uuid}", ${it.getAsJson()}); </script> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]	New: h4. Problems {noformat} == Inline Script Block Line: 77 ---- <script type="text/javascript"> var TestExecuterRPC = <st:bind value="${it}"/>; loadTreeFromFile("${it.propertiesFilePath}", "selectedTests_${it.uuid}", "testsTreeContainer_${it.uuid}", ${it.getAsJson()}); </script> ---- == Inline Event Handler Line: 65 ---- <input type="button" value="Select All" onclick="selectGroupInDiv('testsTreeContainer_${it.uuid}', true);"/> ---- == Inline Event Handler Line: 66 ---- <input type="button" value="Unselect All" onclick="selectGroupInDiv('testsTreeContainer_${it.uuid}', false);"/> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
Summary	Original: [selected-tests-executor] Extract inline script blocks and event handlers in WEB-INF/classes/il/ac/technion/jenkins/plugins/TestExecuter/index.jelly	New: [selected-tests-executor] Extract inline script block and event handlers in WEB-INF/classes/il/ac/technion/jenkins/plugins/TestExecuter/index.jelly