-
Task
-
Resolution: Unresolved
-
Minor
Problem
== Inline Script Block
Line: 41
----
<script>
// Removed OK or Save button for rest of the users
let btnOK = document._getElementsByXPath("//button[text()='OK']")[0];
if (!btnOK) {
var timer = setInterval(function() {
let btnSave = document._getElementsByXPath("//button[text()='Save']")[0];
if (btnSave) {
btnSave.remove();
clearInterval(timer);
}
}, 100);
} else {
btnOK.remove();
}
// Removed delete button
let btnDelete = document._getElementsByXPath("//a[@title='Delete']")[0];
if (btnDelete) {
btnDelete.remove();
}
// Removed Label and Credentials drop-down
let labelKind = document._getElementsByXPath("//div[contains(text(),'Kind')]")[0];
let credentialsTypeSelectBox = document.querySelector("select");
labelKind.remove();
credentialsTypeSelectBox.remove();
</script>
----
Solution
https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
[JENKINS-74400] [BlazeMeterJenkinsPlugin] Extract inline script block in hudson/plugins/blazemeter/BlazemeterCredentialsBAImpl/credentials.jelly
Basil Crow
created issue -
Basil Crow
made changes -
| Description |
Original:
h4. Problems {noformat} == Inline Script Block Line: 41 ---- <script> // Removed OK or Save button for rest of the users let btnOK = document._getElementsByXPath("//button[text()='OK']")[0]; if (!btnOK) { var timer = setInterval(function() { let btnSave = document._getElementsByXPath("//button[text()='Save']")[0]; if (btnSave) { btnSave.remove(); clearInterval(timer); } }, 100); } else { btnOK.remove(); } // Removed delete button let btnDelete = document._getElementsByXPath("//a[@title='Delete']")[0]; if (btnDelete) { btnDelete.remove(); } // Removed Label and Credentials drop-down let labelKind = document._getElementsByXPath("//div[contains(text(),'Kind')]")[0]; let credentialsTypeSelectBox = document.querySelector("select"); labelKind.remove(); credentialsTypeSelectBox.remove(); </script> ---- == Inline Script Block Line: 41 ---- <script> // Removed OK or Save button for rest of the users let btnOK = document._getElementsByXPath("//button[text()='OK']")[0]; if (!btnOK) { var timer = setInterval(function() { let btnSave = document._getElementsByXPath("//button[text()='Save']")[0]; if (btnSave) { btnSave.remove(); clearInterval(timer); } }, 100); } else { btnOK.remove(); } // Removed delete button let btnDelete = document._getElementsByXPath("//a[@title='Delete']")[0]; if (btnDelete) { btnDelete.remove(); } // Removed Label and Credentials drop-down let labelKind = document._getElementsByXPath("//div[contains(text(),'Kind')]")[0]; let credentialsTypeSelectBox = document.querySelector("select"); labelKind.remove(); credentialsTypeSelectBox.remove(); </script> ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] |
New:
h4. Problem {noformat} == Inline Script Block Line: 41 ---- <script> // Removed OK or Save button for rest of the users let btnOK = document._getElementsByXPath("//button[text()='OK']")[0]; if (!btnOK) { var timer = setInterval(function() { let btnSave = document._getElementsByXPath("//button[text()='Save']")[0]; if (btnSave) { btnSave.remove(); clearInterval(timer); } }, 100); } else { btnOK.remove(); } // Removed delete button let btnDelete = document._getElementsByXPath("//a[@title='Delete']")[0]; if (btnDelete) { btnDelete.remove(); } // Removed Label and Credentials drop-down let labelKind = document._getElementsByXPath("//div[contains(text(),'Kind')]")[0]; let credentialsTypeSelectBox = document.querySelector("select"); labelKind.remove(); credentialsTypeSelectBox.remove(); </script> ---- {noformat} h4. Solution [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] |
| Summary | Original: [BlazeMeterJenkinsPlugin] Extract inline script blocks in hudson/plugins/blazemeter/BlazemeterCredentialsBAImpl/credentials.jelly | New: [BlazeMeterJenkinsPlugin] Extract inline script block in hudson/plugins/blazemeter/BlazemeterCredentialsBAImpl/credentials.jelly |