• Type: Task
• Resolution: Unresolved
• Priority: Minor
• Component/s: deployer-framework-plugin
• Labels:

  • CSP

[JENKINS-74417] [deployer-framework] Extract inline script block and event handler in com/cloudbees/plugins/deployer/DeployNowRunAction/configure.jelly

Basil Crow created issue - 2024-10-23 23:56

Basil Crow made changes - 2024-10-24 15:20

Description	Original: h4. Problems {noformat} == Inline Event Handler Line: 78 ---- <a href="#"                    onclick="clearTimeout(r); document.getElementById('autoDeployContainer').innerHTML=''; return false;"> ---- == Inline Script Block Line: 83 ---- <script type="text/javascript">                 x = 60;                 function countdown() {                   if (x > 1) {                     x--;                     document.getElementById("autoDeploy").innerHTML = x;                     r = setTimeout("countdown()", 1000);                   }                   else {                     clearTimeout(r);                     document.getElementById("autoDeploy").innerHTML = 0;                     if (document.forms["deploy"].onsubmit &amp;&amp; !document.forms["deploy"].onsubmit()) {                       return;                     }                     document.forms["deploy"].submit();                   }                 }                 r = setTimeout("countdown()", 1000);               </script> ---- == Inline Event Handler Line: 78 ---- <a href="#"                    onclick="clearTimeout(r); document.getElementById('autoDeployContainer').innerHTML=''; return false;"> ---- == Inline Script Block Line: 83 ---- <script type="text/javascript">                 x = 60;                 function countdown() {                   if (x > 1) {                     x--;                     document.getElementById("autoDeploy").innerHTML = x;                     r = setTimeout("countdown()", 1000);                   }                   else {                     clearTimeout(r);                     document.getElementById("autoDeploy").innerHTML = 0;                     if (document.forms["deploy"].onsubmit &amp;&amp; !document.forms["deploy"].onsubmit()) {                       return;                     }                     document.forms["deploy"].submit();                   }                 }                 r = setTimeout("countdown()", 1000);               </script> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]	New: h4. Problems {noformat} == Inline Script Block Line: 83 ---- <script type="text/javascript">                 x = 60;                 function countdown() {                   if (x > 1) {                     x--;                     document.getElementById("autoDeploy").innerHTML = x;                     r = setTimeout("countdown()", 1000);                   }                   else {                     clearTimeout(r);                     document.getElementById("autoDeploy").innerHTML = 0;                     if (document.forms["deploy"].onsubmit &amp;&amp; !document.forms["deploy"].onsubmit()) {                       return;                     }                     document.forms["deploy"].submit();                   }                 }                 r = setTimeout("countdown()", 1000);               </script> ---- == Inline Event Handler Line: 78 ---- <a href="#"                    onclick="clearTimeout(r); document.getElementById('autoDeployContainer').innerHTML=''; return false;"> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers]
Summary	Original: [deployer-framework] Extract inline script blocks and event handlers in com/cloudbees/plugins/deployer/DeployNowRunAction/configure.jelly	New: [deployer-framework] Extract inline script block and event handler in com/cloudbees/plugins/deployer/DeployNowRunAction/configure.jelly