-
Task
-
Resolution: Unresolved
-
Minor
Problems
== Inline Script Block
Line: 14
----
<script type="text/javascript">
htmlAudioNotifierClient = new HtmlAudioNotifierClient(
'${app.rootUrlFromRequest}',
document.getElementById('htmlAudioNotifierPanel')
);
</script>
----
== Inline Event Handler
Line: 4
----
<a class="enableControl" title="Click to enable audio notifications"
href="#" onclick="htmlAudioNotifierClient.toggle(); return false;">
----
== Inline Event Handler
Line: 8
----
<a class="disableControl" title="Click to disable audio notifications"
href="#" onclick="htmlAudioNotifierClient.toggle(); return false;">
----
Solutions
https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers
[JENKINS-74464] [html-audio-notifier] Extract inline script block and event handlers in WEB-INF/classes/jenkins/plugins/htmlaudio/app/PageDecorator/footer.jelly
Basil Crow
created issue -
Basil Crow
made changes -
| Description |
Original:
h4. Problems {noformat} == Inline Event Handler Line: 4 ---- <a class="enableControl" title="Click to enable audio notifications" href="#" onclick="htmlAudioNotifierClient.toggle(); return false;"> ---- == Inline Event Handler Line: 8 ---- <a class="disableControl" title="Click to disable audio notifications" href="#" onclick="htmlAudioNotifierClient.toggle(); return false;"> ---- == Inline Script Block Line: 14 ---- <script type="text/javascript"> htmlAudioNotifierClient = new HtmlAudioNotifierClient( '${app.rootUrlFromRequest}', document.getElementById('htmlAudioNotifierPanel') ); </script> ---- == Inline Event Handler Line: 4 ---- <a class="enableControl" title="Click to enable audio notifications" href="#" onclick="htmlAudioNotifierClient.toggle(); return false;"> ---- == Inline Event Handler Line: 8 ---- <a class="disableControl" title="Click to disable audio notifications" href="#" onclick="htmlAudioNotifierClient.toggle(); return false;"> ---- == Inline Script Block Line: 14 ---- <script type="text/javascript"> htmlAudioNotifierClient = new HtmlAudioNotifierClient( '${app.rootUrlFromRequest}', document.getElementById('htmlAudioNotifierPanel') ); </script> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers] |
New:
h4. Problems {noformat} == Inline Script Block Line: 14 ---- <script type="text/javascript"> htmlAudioNotifierClient = new HtmlAudioNotifierClient( '${app.rootUrlFromRequest}', document.getElementById('htmlAudioNotifierPanel') ); </script> ---- == Inline Event Handler Line: 4 ---- <a class="enableControl" title="Click to enable audio notifications" href="#" onclick="htmlAudioNotifierClient.toggle(); return false;"> ---- == Inline Event Handler Line: 8 ---- <a class="disableControl" title="Click to disable audio notifications" href="#" onclick="htmlAudioNotifierClient.toggle(); return false;"> ---- {noformat} h4. Solutions [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks] [https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers] |
| Summary | Original: [html-audio-notifier] Extract inline script blocks and event handlers in WEB-INF/classes/jenkins/plugins/htmlaudio/app/PageDecorator/footer.jelly | New: [html-audio-notifier] Extract inline script block and event handlers in WEB-INF/classes/jenkins/plugins/htmlaudio/app/PageDecorator/footer.jelly |