Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74685

[arestocats] Extract inline script block in org/jenkinsci/plugins/arestocats/ArestocatsProjectResultsAction/jobMain.jelly

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • _unsorted

      Problem

      == Inline Script Block
      Line: 7
      ----
      <script type="text/javascript">
                     var results = [${it.summary}];
                     var charts = [];
                     google.charts.load('current', {'packages':['corechart']});
                     google.charts.setOnLoadCallback(drawCharts);
                     function drawCharts(){
                        results.forEach( ( result, index ) => {
                           var data = new google.visualization.DataTable();
                           data.addColumn( 'string', 'X' );
                           var testcase = Object.keys(result)[0];
                           var measurements = result[testcase];
                           var labeling = measurements["outcomes"];
                           labeling.forEach( label => {
                           data.addColumn( 'number', label );
                           });
                          data.addRows(measurements['data']);
                           var options = {
                               'title': 'aRESTocats test-summary',
                               containerId: 'summary',
                               isStacked: true,
                               chartArea: {
                                   left: 100,
                                   width: 600
                               },
                               width: 1000,
                               hAxis: {
                                   title: 'Build Nr.'
                               },
                               vAxis: {
                                   title: 'test-cases'
                               }
                           };
                           var chart = new google.visualization.AreaChart( document.getElementById( 'summary' ) );
                           chart.draw( data, options );
                           charts.push(chart);
                        } );
                     }
                  </script>
      ----
      

      Solution

      https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks

          [JENKINS-74685] [arestocats] Extract inline script block in org/jenkinsci/plugins/arestocats/ArestocatsProjectResultsAction/jobMain.jelly

          Basil Crow created issue -
          Basil Crow made changes -
          Description Original: h4. Problems

          {noformat}
          == Inline Script Block
          Line: 7
          ----
          <script type="text/javascript">
                         var results = [${it.summary}];
                         var charts = [];
                         google.charts.load('current', {'packages':['corechart']});
                         google.charts.setOnLoadCallback(drawCharts);
                         function drawCharts(){
                            results.forEach( ( result, index ) => {
                               var data = new google.visualization.DataTable();
                               data.addColumn( 'string', 'X' );
                               var testcase = Object.keys(result)[0];
                               var measurements = result[testcase];
                               var labeling = measurements["outcomes"];
                               labeling.forEach( label => {
                               data.addColumn( 'number', label );
                               });
                              data.addRows(measurements['data']);
                               var options = {
                                   'title': 'aRESTocats test-summary',
                                   containerId: 'summary',
                                   isStacked: true,
                                   chartArea: {
                                       left: 100,
                                       width: 600
                                   },
                                   width: 1000,
                                   hAxis: {
                                       title: 'Build Nr.'
                                   },
                                   vAxis: {
                                       title: 'test-cases'
                                   }
                               };
                               var chart = new google.visualization.AreaChart( document.getElementById( 'summary' ) );
                               chart.draw( data, options );
                               charts.push(chart);
                            } );
                         }
                      </script>
          ----

          == Inline Script Block
          Line: 7
          ----
          <script type="text/javascript">
                         var results = [${it.summary}];
                         var charts = [];
                         google.charts.load('current', {'packages':['corechart']});
                         google.charts.setOnLoadCallback(drawCharts);
                         function drawCharts(){
                            results.forEach( ( result, index ) => {
                               var data = new google.visualization.DataTable();
                               data.addColumn( 'string', 'X' );
                               var testcase = Object.keys(result)[0];
                               var measurements = result[testcase];
                               var labeling = measurements["outcomes"];
                               labeling.forEach( label => {
                               data.addColumn( 'number', label );
                               });
                              data.addRows(measurements['data']);
                               var options = {
                                   'title': 'aRESTocats test-summary',
                                   containerId: 'summary',
                                   isStacked: true,
                                   chartArea: {
                                       left: 100,
                                       width: 600
                                   },
                                   width: 1000,
                                   hAxis: {
                                       title: 'Build Nr.'
                                   },
                                   vAxis: {
                                       title: 'test-cases'
                                   }
                               };
                               var chart = new google.visualization.AreaChart( document.getElementById( 'summary' ) );
                               chart.draw( data, options );
                               charts.push(chart);
                            } );
                         }
                      </script>
          ----
          {noformat}

          h4. Solution

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          New: h4. Problem

          {noformat}
          == Inline Script Block
          Line: 7
          ----
          <script type="text/javascript">
                         var results = [${it.summary}];
                         var charts = [];
                         google.charts.load('current', {'packages':['corechart']});
                         google.charts.setOnLoadCallback(drawCharts);
                         function drawCharts(){
                            results.forEach( ( result, index ) => {
                               var data = new google.visualization.DataTable();
                               data.addColumn( 'string', 'X' );
                               var testcase = Object.keys(result)[0];
                               var measurements = result[testcase];
                               var labeling = measurements["outcomes"];
                               labeling.forEach( label => {
                               data.addColumn( 'number', label );
                               });
                              data.addRows(measurements['data']);
                               var options = {
                                   'title': 'aRESTocats test-summary',
                                   containerId: 'summary',
                                   isStacked: true,
                                   chartArea: {
                                       left: 100,
                                       width: 600
                                   },
                                   width: 1000,
                                   hAxis: {
                                       title: 'Build Nr.'
                                   },
                                   vAxis: {
                                       title: 'test-cases'
                                   }
                               };
                               var chart = new google.visualization.AreaChart( document.getElementById( 'summary' ) );
                               chart.draw( data, options );
                               charts.push(chart);
                            } );
                         }
                      </script>
          ----
          {noformat}

          h4. Solution

          [https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks]
          Summary Original: [arestocats] Extract inline script blocks in org/jenkinsci/plugins/arestocats/ArestocatsProjectResultsAction/jobMain.jelly New: [arestocats] Extract inline script block in org/jenkinsci/plugins/arestocats/ArestocatsProjectResultsAction/jobMain.jelly

            Unassigned Unassigned
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: