-
Task
-
Resolution: Fixed
-
Minor
-
None
We must imeplement a validation in !https://github.com/fluidicon.png!artifact-manager-s3-plugin/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java at master · jenkinsci/artifact-manager-s3-plugin to make sure HTTPS is mandatory when in FIPS mode.
Validation should raise an error in the form when setting the useHttp flag to true and fail when trying to save it.
Keep in mind this value will be used in the !https://github.com/fluidicon.png!artifact-manager-s3-plugin/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java at master · jenkinsci/artifact-manager-s3-plugin , so we must make sure error (IllegalArgumentException | FormException) is launched only when saving, validate button should simply not perform the validation and return a message stating the reason why validation could not be done.
Steps to Reproduce
Enable use http in the configuration and save it.
Expected Result
The use http cannot be saved
Actual Result
You can configure the plugin to use http instead of https in FIPS mode
[JENKINS-74810] Fix non FIPS compliant TLS usage in artifact-manager-s3
| Description |
Original:
We must imeplement a validation in [!https://github.com/fluidicon.png!artifact-manager-s3-plugin/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java at master · jenkinsci/artifact-manager-s3-plugin|https://github.com/jenkinsci/artifact-manager-s3-plugin/blob/master/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java#L202-L205] to make sure HTTPS is mandatory when in FIPS mode.
Validation should raise an error in the form when setting the {{useHttp}} flag to true and fail when trying to save it. Keep in mind this value will be used in the [!https://github.com/fluidicon.png!artifact-manager-s3-plugin/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java at master · jenkinsci/artifact-manager-s3-plugin|https://github.com/jenkinsci/artifact-manager-s3-plugin/blob/master/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java#L111] , so we must make sure error ({{{}IllegalArgumentException{}}} | {{{}FormException{}}}) is launched *only when saving,* validate button should simply not perform the validation and return a message stating the reason why validation could not be done. h2. Steps to Reproduce Enable use http in the configuration and save it. h2. Expected Result The use http cannot be saved h2. Actual Result You can configure the plugin to use http instead of https in FIPS mode |
New:
We must imeplement a validation in [!https://github.com/fluidicon.png!artifact-manager-s3-plugin/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java at master · jenkinsci/artifact-manager-s3-plugin|https://github.com/jenkinsci/artifact-manager-s3-plugin/blob/master/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java#L202-L205] to make sure HTTPS is mandatory when in FIPS mode.
Validation should raise an error in the form when setting the {{useHttp}} flag to true and fail when trying to save it. Keep in mind this value will be used in the [!https://github.com/fluidicon.png!artifact-manager-s3-plugin/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java at master · jenkinsci/artifact-manager-s3-plugin|https://github.com/jenkinsci/artifact-manager-s3-plugin/blob/master/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java#L111] , so we must make sure error ({{{}IllegalArgumentException{}}} | {{{}FormException{}}}) is launched *only when saving,* validate button should simply not perform the validation and return a message stating the reason why validation could not be done. h2. Steps to Reproduce Enable use http in the configuration and save it. h2. Expected Result The use http cannot be saved h2. Actual Result You can configure the plugin to use http instead of https in FIPS mode |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: In Review [ 10005 ] | New: Resolved [ 5 ] |