-
New Feature
-
Resolution: Unresolved
-
Major
-
None
In the attached patch, it will allow plugins to extend a class and provide icons to also use along with the default stars. See original thread in URL. The patch here differs from there, just refactored names a little bit. Please review patch, and let me know if I can commit it?
I looked at the change.
I think the abstraction of PromotionIconExtension should be modified. Instead of getPlugin()/getName(), this extension point should define a well-known view (such as icon.jelly) that's responsible for rendering the promotion icon. You can then provide a subtype that draws a static icon with the <img> tag and then have such class define abstract String getIconUrl() kind of a method.
Also, instead of defining 7 subtypes for each color, I recommend extending ExtensionFinder and just construct 7 instances of the same class with different parameters.