Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8916

Allowing same type of parameter for triggered build more than once seems redundant

      While working on JENKINS-7377 I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
      For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
      The only type where it might make sense is "Parameters from properties file".

      I think for every type of parameters a simple checkbox is sufficient.

      I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

          [JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant

          Fred G created issue -
          Fred G made changes -
          Assignee Original: huybrechts [ huybrechts ] New: Fred G [ fredg ]

          Fred G added a comment -

          I'm trying to replace the following jelly script in BuildTriggerConfig/config.jelly:

          <f:hetero-list name="configs" hasHeader="true"
                         descriptors="${descriptor.getBuilderConfigDescriptors()}"
                         items="${instance.configs}"
                         addCaption="${%Add Parameters}"
          />
          

          with something like

          <f:descriptorList descriptors="${descriptor.getBuilderConfigDescriptors()}" instances="${instance.configs}"/>
          

          It looks ok, but unfortunately does not save which type of parameter was selected (checked).

          Could you give me hint what I need to do to get it working? Is there any other jelly tag that deals with a list and displays checkboxes? (I noticed that <f:hetero-radio/> exists, but unfortunately it allows only radio buttons.)

          Best Regards,

          Fred

          Fred G added a comment - I'm trying to replace the following jelly script in BuildTriggerConfig/config.jelly: <f:hetero-list name= "configs" hasHeader= " true " descriptors= "${descriptor.getBuilderConfigDescriptors()}" items= "${instance.configs}" addCaption= "${%Add Parameters}" /> with something like <f:descriptorList descriptors= "${descriptor.getBuilderConfigDescriptors()}" instances= "${instance.configs}" /> It looks ok, but unfortunately does not save which type of parameter was selected (checked). Could you give me hint what I need to do to get it working? Is there any other jelly tag that deals with a list and displays checkboxes? (I noticed that <f:hetero-radio/> exists, but unfortunately it allows only radio buttons.) Best Regards, Fred
          Fred G made changes -
          Assignee Original: Fred G [ fredg ] New: huybrechts [ huybrechts ]
          Fred G made changes -
          Assignee Original: huybrechts [ huybrechts ] New: Fred G [ fredg ]
          Fred G made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Fred G added a comment -

          Fred G added a comment - Pull request: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/20

          Code changed in jenkins
          User: Fred G
          Path:
          src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly
          src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly
          http://jenkins-ci.org/commit/parameterized-trigger-plugin/3f6097a82679a76d8b0b03498d9c9a392b77f6fc
          Log:
          [FIXED JENKINS-8916] Allowing same type of parameter for triggered build
          more than once seems redundant

          It requires Jenkins core version 1.463 to work, but it's fully
          backwards compatible.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Fred G Path: src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly http://jenkins-ci.org/commit/parameterized-trigger-plugin/3f6097a82679a76d8b0b03498d9c9a392b77f6fc Log: [FIXED JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant It requires Jenkins core version 1.463 to work, but it's fully backwards compatible.
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Fred G
          Path:
          src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly
          src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly
          http://jenkins-ci.org/commit/parameterized-trigger-plugin/6e80ae37591b708b321b27a80a8d32012949f6a0
          Log:
          Merge pull request #20 from fredg02/master

          [FIXED JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant

          Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/76d4c9b...6e80ae3

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Fred G Path: src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly http://jenkins-ci.org/commit/parameterized-trigger-plugin/6e80ae37591b708b321b27a80a8d32012949f6a0 Log: Merge pull request #20 from fredg02/master [FIXED JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/76d4c9b...6e80ae3

            danielbeck Daniel Beck
            fredg Fred G
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: